Skip to content

Commit 99ddfbb

Browse files
committed
Added error checking for blank names and values
1 parent e3bd716 commit 99ddfbb

File tree

4 files changed

+23
-2
lines changed

4 files changed

+23
-2
lines changed

Snippets/Snippets.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,13 @@ public function config() {
2626
);
2727
}
2828

29+
public function errors() {
30+
return array(
31+
"name_empty" => plugin_lang_get("error_name_empty"),
32+
"value_empty" => plugin_lang_get("error_value_empty"),
33+
);
34+
}
35+
2936
public function hooks() {
3037
return array(
3138
"EVENT_MENU_ACCOUNT" => "menu_account",

Snippets/lang/strings_english.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ $s_plugin_Snippets_name = "Snippets";
88
$s_plugin_Snippets_description = "Allow users to save blocks of text";
99
$s_plugin_Snippets_version = "0.2";
1010

11+
$s_plugin_Snippets_error_name_empty = "The snippet name is empty.";
12+
$s_plugin_Snippets_error_value_empty = "The snippet value is empty.";
13+
1114
$s_plugin_Snippets_select_label = "Snippets: ";
1215
$s_plugin_Snippets_select_default = "--";
1316

Snippets/pages/snippet_create.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,13 @@
1616
$name = gpc_get_string("name");
1717
$value = gpc_get_string("value");
1818

19+
if (is_blank($name)) {
20+
plugin_error("name_empty");
21+
}
22+
if (is_blank($value)) {
23+
plugin_error("value_empty");
24+
}
25+
1926
$snippet = new Snippet(0, $name, $value, $user_id);
2027
$snippet->save();
2128

Snippets/pages/snippet_list_action.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,12 @@ function array_object_properties($arr, $prop) {
9595
if ($snippet->name != $new_name
9696
|| $snippet->value != $new_value)
9797
{
98-
$snippet->name = $new_name;
99-
$snippet->value = $new_value;
98+
if (!is_blank($new_name)) {
99+
$snippet->name = $new_name;
100+
}
101+
if (!is_blank($new_value)) {
102+
$snippet->value = $new_value;
103+
}
100104

101105
$snippet->save();
102106
}

0 commit comments

Comments
 (0)