Implemented list update and other UX/lang tweaks

Author: amyreese

Snippets/lang/strings_english.txt

@@ -26,6 +26,7 @@ $s_plugin_Snippets_create_name = "Name";
 $s_plugin_Snippets_create_value = "Snippet";
 
 $s_plugin_Snippets_action_go = "Go";
+$s_plugin_Snippets_action_create = "create";
 $s_plugin_Snippets_action_edit = "Edit";
 $s_plugin_Snippets_action_delete = "Delete";
 $s_plugin_Snippets_action_delete_confirm = "Do you really want to delete the following snippets?";

Snippets/pages/snippet_create.php

@@ -20,5 +20,5 @@
 $snippet->save();
 
 form_security_purge("plugin_snippets_create");
-print_successful_redirect(plugin_page("snippet_list", true) . $global ? "&global=true" : "");
+print_successful_redirect(plugin_page("snippet_list", true) . ($global ? "&global=true" : ""));
 

Snippets/pages/snippet_list.php

@@ -20,8 +20,9 @@
 ?>
 
 <br/>
-<form action="<?php echo plugin_page("snippet_list_action"), $global ? "&global=true" : "" ?>" method="post">
+<form action="<?php echo plugin_page("snippet_list_action") ?>" method="post">
 <?php echo form_security_field("plugin_Snippets_list_action") ?>
+<?php if ($global): ?><input type="hidden" name="global" value="true"/><?php endif ?>
 <table class="width75" align="center">
 
 <tr>
@@ -30,7 +31,7 @@
 </tr>
 
 <tr class="row-category">
-<td> </td>
+<td width="5%"> </td>
 <td><?php echo plugin_lang_get("list_name") ?></td>
 <td><?php echo plugin_lang_get("list_value") ?></td>
 </tr>
@@ -61,24 +62,25 @@
 <br/>
 <form action="<?php echo plugin_page("snippet_create") ?>" method="post">
 <?php echo form_security_field("plugin_snippets_create") ?>
+<?php if ($global): ?><input type="hidden" name="global" value="true"/><?php endif ?>
 <table class="width75" align="center">
 
 <tr>
-<td class="form-title" colspan="2">Create Snippet</td>
+<td class="form-title" colspan="2"><?php echo plugin_lang_get($global ? "create_global_title" : "create_title") ?></td>
 </tr>
 
 <tr <?php echo helper_alternate_class() ?>>
-<td class="category">Short Name</td>
+<td class="category"><?php echo plugin_lang_get("create_name") ?></td>
 <td><input name="name"/></td>
 </tr>
 
 <tr <?php echo helper_alternate_class() ?>>
-<td class="category">Full Text</td>
+<td class="category"><?php echo plugin_lang_get("create_value") ?></td>
 <td><textarea name="value" cols="80" rows="6"></textarea></td>
 </tr>
 
 <tr>
-<td class="center" colspan="2"><input type="submit"/></td>
+<td class="center" colspan="2"><input type="submit" value="<?php echo plugin_lang_get("action_create") ?>"/></td>
 </tr>
 
 </table>

Snippets/pages/snippet_list_action.php

@@ -16,7 +16,13 @@
 
 $action = gpc_get_string("action");
 
-$snippet_list = gpc_get_int_array("snippet_list");
+$snippet_list = gpc_get_int_array("snippet_list", array());
+
+if (count($snippet_list) < 1) {
+	form_security_purge("plugin_Snippets_list_action");
+	print_header_redirect(plugin_page("snippet_list", true) . ($global ? "&global=true" : ""));
+}
+
 $snippets = Snippet::load_by_id($snippet_list, $user_id);
 
 function array_object_properties($arr, $prop) {
@@ -43,8 +49,9 @@ function array_object_properties($arr, $prop) {
 ?>
 
 <br/>
-<form action="<?php echo plugin_page("snippet_list_action"), $global ? "&global=true" : "" ?>" method="post">
+<form action="<?php echo plugin_page("snippet_list_action") ?>" method="post">
 <?php echo form_security_field("plugin_Snippets_list_action") ?>
+<?php if ($global): ?><input type="hidden" name="global" value="true"/><?php endif ?>
 <input type="hidden" name="action" value="update"/>
 <table class="width75" align="center">
 
@@ -81,6 +88,23 @@ function array_object_properties($arr, $prop) {
 
 ### UPDATE
 } elseif ($action == "update") {
+	foreach($snippets as $snippet_id => $snippet) {
+		$new_name = gpc_get_string("name_{$snippet_id}");
+		$new_value = gpc_get_string("value_{$snippet_id}");
+
+		if ($snippet->name != $new_name
+			|| $snippet->value != $new_value)
+		{
+			$snippet->name = $new_name;
+			$snippet->value = $new_value;
+
+			$snippet->save();
+		}
+	}
+
+	form_security_purge("plugin_Snippets_list_action");
+	print_successful_redirect(plugin_page("snippet_list", true) . ($global ? "&global=true" : ""));
+
 }