Fix JSHint static analysis warnings

Author: dregad

files/snippets.js

@@ -2,7 +2,7 @@
 // Copyright (c) 2012 - 2021  MantisBT Team - [email protected]
 // Licensed under the MIT license
 
-jQuery(document).ready(function($) {
+jQuery(function($) {
 	"use strict";
 
 	/**
@@ -34,13 +34,13 @@ jQuery(document).ready(function($) {
 		 */
 		function SnippetsUI(data) {
 			$(data.selector).each(function() {
-				var textarea = $(this);
+				const textarea = $(this);
 
 				// Only display snippets selector if there are any
 				if (Array.isArray(data.snippets) && data.snippets.length > 0) {
 					try {
 						// Create Snippets select
-						var select = $("<select></select>");
+						const select = $("<select></select>");
 
 						// Set the Tab index equal to the associated textareas
 						select.attr('tabindex', textarea.attr('tabindex'));
@@ -49,26 +49,26 @@ jQuery(document).ready(function($) {
 
 						$.each(data.snippets, function(key, snippet) {
 							// Escape single quotes
-							var value = snippet.value.replace(/'/g, "&#39;");
+							const value = snippet.value.replace(/'/g, "&#39;");
 
 							select.append(
 								"<option value='" + value + "' title='" + value + "'>" + snippet.name + "</option>"
 							);
 						});
 
-						select.change(function() {
-							var text = $(this).val();
+						select.on('change', function() {
+							const text = $(this).val();
 							textarea.textrange('replace', text);
 							$(this).val("");
 						});
 
-						var label = $("<label>" + data.label + " </label>");
+						const label = $("<label>" + data.label + " </label>");
 						label.append(select);
 
 						textarea.before(label);
 						textarea.before('<div class="space-4"></div>');
 					} catch(e) {
-						console.error('Error occured while generating Snippets UI', e);
+						console.error('Error occurred while generating Snippets UI', e);
 					}
 				}
 			});
@@ -77,27 +77,25 @@ jQuery(document).ready(function($) {
 		// If we have any textareas (excluding those in the plugin's own
 		// edit pages) then fetch Snippets
 		if ($("textarea").not(".snippetspatternhelp textarea").length > 0) {
-			var bug_id = 0;
-
 			// Retrieve the bug id from the known forms where we know
 			// Snippets-supported textareas exist.
- 			var selector = '';
-			var known_forms = ['bug_update.php', 'bugnote_add.php', 'bug_reminder.php'];
+			const known_forms = ['bug_update.php', 'bugnote_add.php', 'bug_reminder.php'];
+			let selector = '';
 			known_forms.forEach(function (value) {
 				selector += "form[action='" + value + "'], ";
 			});
 			selector = selector.replace(/, $/, '');
-			bug_id = $(selector).find("input[name='bug_id']").val();
+			const bug_id = $('input[name="bug_id"]', selector).val();
 
-			var url = rest_api('data');
+			let url = rest_api('data');
 			if (bug_id > 0) {
 				url += "/" + bug_id;
 			}
 
 			$.getJSON(url)
 				.done(SnippetsUI)
 				.fail(function() {
-					console.error('Error occured while retrieving Snippets');
+					console.error('Error occurred while retrieving Snippets');
 				});
 		}
 	}
@@ -137,12 +135,12 @@ jQuery(document).ready(function($) {
 	}
 
 	// Snippet list behaviors
-	$("input.snippets_select_all").change(function() {
+	$("input.snippets_select_all").on('change', function() {
 		$("input[name='snippet_list[]']").prop("checked", $(this).prop("checked"));
 	});
 
 	// Snippet pattern help
-	var selector = $(".snippetspatternhelp");
+	const selector = $(".snippetspatternhelp");
 	if (selector.length > 0 ) {
 		$.get(rest_api('help'))
 			.done(function (data) {