Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace in Function(Q) QENS Fitting not finding correct files #38827

Open
sf1919 opened this issue Feb 12, 2025 · 1 comment · May be fixed by #39067
Open

Add workspace in Function(Q) QENS Fitting not finding correct files #38827

sf1919 opened this issue Feb 12, 2025 · 1 comment · May be fixed by #39067
Assignees
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Reported By User Issues that were found or highlighted by a user/scientist

Comments

@sf1919
Copy link
Contributor

sf1919 commented Feb 12, 2025

Original reporter: Sanghamitra Mukhopadhyay, ISIS

Describe the bug
The interface Function(Q) has the Add Workspace function. However this is restricted to files with names ending with *_Result. It cannot find files that have been saved using Save Project. The workflow that generates the files to be used creates a group called *_Results with a single workspace called *_Result. The Save function creates a single workspace with name *_Results. This then cannot be found as it has the extra s that the Add Workspace function does not recognise.

To Reproduce
Navigate to
Interfaces -> Inelastic -> QENS Fitting -> Function(Q)

Click Add Workspace and see what files are available.

Expected behavior
Users should be able to access files they have saved in Mantid (including through Save Project) and use them in the interfaces they are intended for.

Platform/Version (please complete the following information):

  • OS: Windows
  • Mantid Version: Present in v6.11 and the current nightly (not tested on earlier versions so unclear when this issue started)

Additional context
It looks like the functionality to do this was introduced in v6.11 (see #37657 for more details). This looks to be an edge case where a group workspace that contains only a single workspace is being saved as a single workspace with the group name rather than the individual workspace name.

@sf1919 sf1919 added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS labels Feb 12, 2025
@SpencerHowells
Copy link

There are 2 bugs involved here:
1 There is a regresson in all (I think) the fitting tabs of QENS fitting whereby the Result ws is created as a Group. I suspect that it uses the the same method as the Workspaces which should be a Group.
2 If you use the Save button on the gui the file created is the correct ws. However if you Save Project the file created has the Group name instead of the workspace name.

@sf1919 sf1919 added the Reported By User Issues that were found or highlighted by a user/scientist label Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Reported By User Issues that were found or highlighted by a user/scientist
Projects
Development

Successfully merging a pull request may close this issue.

3 participants