Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User defined fit function box hidden behind scroll bar #37579

Open
jclarkeSTFC opened this issue Jun 20, 2024 · 4 comments · May be fixed by #39049
Open

User defined fit function box hidden behind scroll bar #37579

jclarkeSTFC opened this issue Jun 20, 2024 · 4 comments · May be fixed by #39049
Assignees
@SilkeSchomann
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS macOS Only The issues related to macOS only.
Milestone
Release 6.13

Comments

@jclarkeSTFC
Copy link
Contributor

jclarkeSTFC commented Jun 20, 2024 •
edited
Loading

Describe the bug

If there is a scroll bar in the fit options, then it's impossible to click the button in the Formula box in order to open the User Function Dialog.

To Reproduce
Open the fit toolbar on a plot, size the window vertically such that a scroll bar appears, add a UserFunction, then try and open the User Function Dialog

Expected behavior

Button can be clicked

Screenshots

Screenshot 2024-06-20 at 14 20 57

Platform/Version (please complete the following information):

  • OS: macOS
  • OS Version: 12.7.5
  • Mantid Version 6.10.0rc1, 6.9.1

Additional context

Found during smoke testing.
@jclarkeSTFC jclarkeSTFC added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) macOS Only The issues related to macOS only. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels Jun 20, 2024
@jclarkeSTFC jclarkeSTFC mentioned this issue Jun 20, 2024
Closed
12 tasks
@sf1919 sf1919 moved this to Backlog in Mantid Maintenance Jun 27, 2024
@jhaigh0
Copy link
Contributor

jhaigh0 commented Jul 1, 2024

Possibly mac specific, looks okay on windows

Image

@jhaigh0
Copy link
Contributor

jhaigh0 commented Jul 17, 2024

Had a look on ubuntu and looks okay, so just a mac thing

Image

@SilkeSchomann SilkeSchomann self-assigned this Nov 13, 2024
@rbauststfc rbauststfc moved this from Backlog to Assigned in Mantid Maintenance Nov 29, 2024
@SilkeSchomann
Copy link
Contributor

I've just re-tested this on macOS with Mantid nightly from 17th of January 2025. It is not possible anymore to resize the window vertically so that a scrollbar appears. As a consequence, the User Function Dialog button always remains accessible.

@github-project-automation github-project-automation bot moved this from Todo to Done in ISIS Core Feb 4, 2025
@github-project-automation github-project-automation bot moved this from Assigned to Done in Mantid Maintenance Feb 4, 2025
@SilkeSchomann
Copy link
Contributor

SilkeSchomann commented Feb 24, 2025 •
edited
Loading

This issue appeared again during smoke testing and seems to affect at least some installations on macOS.

@SilkeSchomann SilkeSchomann reopened this Feb 24, 2025
@github-project-automation github-project-automation bot moved this from Done to In progress in Mantid Maintenance Feb 24, 2025
@SilkeSchomann SilkeSchomann mentioned this issue Feb 24, 2025
Closed
12 tasks
@jhaigh0 jhaigh0 removed the status in ISIS Core Feb 24, 2025
@SilkeSchomann SilkeSchomann linked a pull request Mar 13, 2025 that will close this issue
Open
@SilkeSchomann SilkeSchomann moved this to Awaiting Approval in ISIS Core Mar 14, 2025
@SilkeSchomann SilkeSchomann moved this from In progress to Ready for Review in Mantid Maintenance Mar 14, 2025
@SilkeSchomann SilkeSchomann linked a pull request Mar 14, 2025 that will close this issue
Fix for User Function Dialog button hidden behind scroll bar #39049
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SilkeSchomann SilkeSchomann

Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS macOS Only The issues related to macOS only.
Projects
ISIS Core
Status: Awaiting Approval
Mantid Maintenance
Status: Ready for Review
Milestone
Release 6.13
Development

Successfully merging a pull request may close this issue.

Fix for User Function Dialog button hidden behind scroll bar mantidproject/mantid
4 participants
@thomashampson @jhaigh0 @SilkeSchomann @jclarkeSTFC