More API 16 fixes, toLowerCase with root locale

Author: maltaisn

icondialog/src/main/java/com/maltaisn/icondialog/IconFilter.java

@@ -22,11 +22,12 @@
 package com.maltaisn.icondialog;
 
 
-import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
-
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Locale;
+
+import androidx.annotation.NonNull;
+import androidx.annotation.Nullable;
 
 /**
  * Default icon searcher used by IconDialog
@@ -123,7 +124,7 @@ public List<Icon> getIconsForSearch(@Nullable String search) {
                 if (normalizeSearch) {
                     searchTerms[i] = IconHelper.normalizeText(searchTerms[i]);
                 } else {
-                    searchTerms[i] = searchTerms[i].toLowerCase();
+                    searchTerms[i] = searchTerms[i].toLowerCase(Locale.ROOT);
                 }
             }
         }

icondialog/src/main/java/com/maltaisn/icondialog/IconHelper.java

@@ -27,10 +27,6 @@
 import android.util.Log;
 import android.util.SparseArray;
 
-import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
-import androidx.annotation.XmlRes;
-
 import org.xmlpull.v1.XmlPullParser;
 import org.xmlpull.v1.XmlPullParserException;
 
@@ -39,6 +35,11 @@
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
+import java.util.Locale;
+
+import androidx.annotation.NonNull;
+import androidx.annotation.Nullable;
+import androidx.annotation.XmlRes;
 
 @SuppressWarnings({"WeakerAccess", "unused"})
 public class IconHelper {
@@ -177,7 +178,7 @@ SparseArray<Icon> getIcons() {
     public Label getLabel(String name) {
         if (!dataLoaded) return null;
 
-        name = name.toLowerCase();
+        name = name.toLowerCase(Locale.ROOT);
         if (name.startsWith("_")) {
             name = name.substring(1);
             int index = Collections.binarySearch(groupLabels, name);
@@ -636,7 +637,7 @@ private static class LabelRef {
     static String normalizeText(String text) {
         // NOTE: Might have to change this method if more translations are made
         // For example, right now it would remove all chinese and arabic characters
-        text = text.toLowerCase().trim();
+        text = text.toLowerCase(Locale.ROOT).trim();
         String normalized = Normalizer.normalize(text, Normalizer.Form.NFKD);
         StringBuilder sb = new StringBuilder();
         for (int i = 0; i < normalized.length(); i++) {

icondialog/src/main/java/com/maltaisn/icondialog/StickyHeaderDecoration.java

@@ -118,7 +118,7 @@ private void setHeaderViewHolder(int position, View parent) {
 
         if (stickyHeaderHeight == -1) {
             // Measure parent RecyclerView
-            int parentWidth = parent.getWidth() + parent.getPaddingStart() + parent.getPaddingEnd();
+            int parentWidth = parent.getWidth() + parent.getPaddingLeft() + parent.getPaddingRight();
             int widthSpec = View.MeasureSpec.makeMeasureSpec(parentWidth, View.MeasureSpec.EXACTLY);
             int heightSpec = View.MeasureSpec.makeMeasureSpec(parent.getHeight(), View.MeasureSpec.UNSPECIFIED);