Skip to content

Reenable verification #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Reenable verification #69

wants to merge 2 commits into from

Conversation

brianmcmichael
Copy link
Contributor

Fixes to dapptools verify have been merged at dapphub/dapptools#287

This re-enables the etherscan verification flags for the kovan deployment and adds them to the script for the mainnet deployment.

Will require a dapptools update to work.

@gbalabasquer
Copy link
Contributor

The thing is even with the dapp verify working we had some issues verifying some contracts (randomly didn't work, maybe some timeout in the etherscan api) + all the contracts created by factories are not being verified.
I wouldn't enable this functionality as it is now, but instead I'd create a new independent script that runs after a deployment is done, which would check each address, get the solidity code and verify them.
That will also keep the deployment script is not getting slower than already is.

@brianmcmichael
Copy link
Contributor Author

Ok, I'll need to think about the best way to do that. Currently dapptools does not extract the source to an output location (only bin and abi), and it's currently only available from a temporary output path tracked within dapptools that gets removed after the deployment.

To do this via an external script we would probably need to request another update to dapptools that extracts the flattened source to a location where it can be accessed after the deployment. We'd also need to be able to match that code up to the address somehow. I'll poke around in this code to see if there's a better way.

@gbalabasquer
Copy link
Contributor

Yeah let's think it more in detail. If we merge this we will end up having a slower deployment script with just a few contracts verified.
On the other hand, the deployment scripts run on nix, so it uses a defined dependency of dapptools, we should update a couple more places to use the latest version with dapp verify fixed.
Closing this PR for now.

@gbalabasquer gbalabasquer deleted the reenable-verify branch January 10, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants