-
Notifications
You must be signed in to change notification settings - Fork 598
refactor(typescript): migrate BaseAuthenticator and OAuthPasswordGrant #2883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
58d499e to
93910de
Compare
|
Some tests with 'continue-on-error: true' have failed:
|
|
What are the alternatives for Is there any chance you could return a copy of the response (before it was read)? (or copy the response, read that one and send the original) |
|
Hi @BoussonKarel. As you've noticed, there's no clear migration path from these properties which was an oversight. I'm not sure if this is the way forward however, I should be able to take a better look later this week to align the password authenticator with other authenticators instead in backwards compatible way. |
isEmptycalls from the authenticators and relies on native mechanisms instead.responseTextandresponseJSONreturned by the OAuth2PasswordGrantAuthenticator.