Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and enable mxresolv.TestLookupError #155

Closed
vtopc opened this issue Dec 20, 2022 · 0 comments · Fixed by #175
Closed

Fix and enable mxresolv.TestLookupError #155

vtopc opened this issue Dec 20, 2022 · 0 comments · Fixed by #175
Labels
broken test

Comments

@vtopc
Copy link
Contributor

vtopc commented Dec 20, 2022 •
edited
Loading 

=== RUN   TestLookupError/kaboom
    mxresolv_test.go:119: 
        	Error Trace:	/home/runner/work/holster/holster/mxresolv/mxresolv_test.go:119
        	Error:      	Expect "lookup kaboom: Temporary failure in name resolution" to match "lookup kaboom.*: no such host"
        	Test:       	TestLookupError/kaboom
    mxresolv_test.go:126: 
        	Error Trace:	/home/runner/work/holster/holster/mxresolv/mxresolv_test.go:126
        	Error:      	Should be false
        	Test:       	TestLookupError/kaboom
    mxresolv_test.go:131: 
        	Error Trace:	/home/runner/work/holster/holster/mxresolv/mxresolv_test.go:131
        	Error:      	Expect "lookup kaboom: Temporary failure in name resolution" to match "lookup kaboom.*: no such host"
        	Test:       	TestLookupError/kaboom
@vtopc vtopc mentioned this issue Dec 20, 2022
Merged
@vtopc vtopc changed the title Fix mxresolv.TestLookupError Fix and enable mxresolv.TestLookupError Dec 20, 2022
@thrawn01 thrawn01 mentioned this issue Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
broken test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mxresolv.Lookup() now properly randomized hosts in some situations mailgun/holster
1 participant
@vtopc