Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WooCommerce Plugin Check #1226

Closed
chihsuan opened this issue Dec 17, 2024 · 5 comments
Closed

Remove WooCommerce Plugin Check #1226

chihsuan opened this issue Dec 17, 2024 · 5 comments

Comments

@chihsuan
Copy link

Description:

This is a follow-up to Issue #1170, where the Plugin Dependencies feature was introduced (thanks @ryanhungate for adding this! 🙏 ), but the existing WooCommerce plugin check was not removed.

Since WordPress now handles plugin dependencies natively, ideally, we don't need to check the plugin now.

Problem:

  • Users with non-standard WooCommerce folder names still encounter error messages. Specifically, the Mailchimp for WooCommerce plugin is available in the WooCommerce onboarding wizard. However, when they use a custom folder name for WooCommerce, this causes an issue that users will get an error message.
  • To bypass this error, I understand that users can define the RUNNING_CUSTOM_WOOCOMMERCE constant, but it's not a good user experience.
  • Maintaining redundant code adds unnecessary complexity and potential points of failure.

Suggested Changes:

  • Deprecate/remove the mailchimp_check_woocommerce_plugin_status and mailchimp_check_woocommerce_is_installed functions.

References:

@ryanhungate
Copy link
Collaborator

@chihsuan thanks for the follow up :) yeah we'll get this put into our next 5.1 release no problem and report back when it's complete. We had just pushed out 5.0 today so there's no guarantee on the next timeline as of right now, but I would assume after the new year this will follow soon after 👍

@ryanhungate
Copy link
Collaborator

@chihsuan just to let you know - we're going to be adding this feature you're requesting into the next version. Basically just removing those internal checks as you had suggested.

@chihsuan
Copy link
Author

Thanks for letting me know! @ryanhungate That would be great! 👍

@khungate
Copy link
Collaborator

khungate commented Feb 7, 2025

Hi @chihsuan, we wanted to let you know this went out earlier this week in v5.2. Appreciate your patience and feedback, please let us know if you still need any help and we'll be glad to reopen and troubleshoot further.

@khungate khungate closed this as completed Feb 7, 2025
@chihsuan
Copy link
Author

chihsuan commented Feb 8, 2025

Thanks @khungate, I'll try it out with the new version. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants