-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove WooCommerce Plugin Check #1226
Comments
@chihsuan thanks for the follow up :) yeah we'll get this put into our next 5.1 release no problem and report back when it's complete. We had just pushed out 5.0 today so there's no guarantee on the next timeline as of right now, but I would assume after the new year this will follow soon after 👍 |
Thanks for letting me know! @ryanhungate That would be great! 👍 |
Hi @chihsuan, we wanted to let you know this went out earlier this week in v5.2. Appreciate your patience and feedback, please let us know if you still need any help and we'll be glad to reopen and troubleshoot further. |
Thanks @khungate, I'll try it out with the new version. Nice work! |
Description:
This is a follow-up to Issue #1170, where the Plugin Dependencies feature was introduced (thanks @ryanhungate for adding this! 🙏 ), but the existing WooCommerce plugin check was not removed.
Since WordPress now handles plugin dependencies natively, ideally, we don't need to check the plugin now.
Problem:
RUNNING_CUSTOM_WOOCOMMERCE
constant, but it's not a good user experience.Suggested Changes:
mailchimp_check_woocommerce_plugin_status
andmailchimp_check_woocommerce_is_installed
functions.References:
The text was updated successfully, but these errors were encountered: