Skip to content

Commit b4284f7

Browse files
jurahulmahesh-attarde
authored andcommitted
[LLVM-Test] Fix a regression in test dependencies introduced by 0e14973 (llvm#161623)
Add `UnitTests` as an explicit dependency for `check-llvm` and `llvm-test-depends`. In llvm#161442, the intent was to remove `UnitTests` as a dependency for the individual per-directory `check-llvm-*` test suites created but not to drop it from `check-llvm` or `llvm-test-depends`. This missing dependency will cause LLVM unit tests to be not rebuilt and resulting in either `warning: test suite 'LLVM-Unit' contained no tests` or running stale running versions of the unit tests when running `check-llvm`.
1 parent 3ef6597 commit b4284f7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

llvm/test/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ if (LLVM_INCLUDE_SPIRV_TOOLS_TESTS)
247247
list(APPEND LLVM_TEST_DEPENDS spirv-link)
248248
endif()
249249

250-
add_custom_target(llvm-test-depends DEPENDS ${LLVM_TEST_DEPENDS})
250+
add_custom_target(llvm-test-depends DEPENDS ${LLVM_TEST_DEPENDS} UnitTests)
251251
set_target_properties(llvm-test-depends PROPERTIES FOLDER "LLVM/Tests")
252252

253253
if(LLVM_BUILD_TOOLS)
@@ -259,7 +259,7 @@ endif()
259259
add_lit_testsuite(check-llvm "Running the LLVM regression tests"
260260
${CMAKE_CURRENT_BINARY_DIR}
261261
${exclude_from_check_all}
262-
DEPENDS ${LLVM_TEST_DEPENDS}
262+
DEPENDS ${LLVM_TEST_DEPENDS} UnitTests
263263
)
264264
set_target_properties(check-llvm PROPERTIES FOLDER "LLVM/Tests")
265265

0 commit comments

Comments
 (0)