You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Preview site should actually be "View site" because it is not really a preview.
Also you should be redirecting to the production url and not the preview one ex: /maglev/summer-snow-2751/preview/en/riseup
The text was updated successfully, but these errors were encountered:
I would actually like it to be a preview on a separate path.
Currently Maglev serves all pages from the PagePreviewController which has no caching and the like.
Keeping this as is but then actually serving the saved page from a new PageController that has caching, maybe even the ability to configure page caching with some kind of configurable cache sweeper where you can make a API request to expire the CDN cache on update.
Our NextJS+Strapi apps usually have this kind of setup as it means the CDN is basically just shipping out static files. Or even just having the save action cause the page to be written to the public folder (configurable per page as some pages will have dynamic content.)
The "Preview" button / feature needs some work because it confuses developers.
We should have 2 different rendering controllers :
PagePreviewController -> called when clicking on the "Preview" button. Strictly no cache.
PageController -> the real rendering controller. Caching enabled and configured through the maglev.rb configuration file? (or use the default values from the main Rails app).
Last point, here is the screenshot of the topbar from a product based on Maglev which creates a static version of a Maglev site and publishes it to Github pages 👇
Preview site should actually be "View site" because it is not really a preview.
Also you should be redirecting to the production url and not the preview one ex: /maglev/summer-snow-2751/preview/en/riseup
The text was updated successfully, but these errors were encountered: