Skip to content

Commit 7107cfe

Browse files
author
majid.akbaristerabadi
committed
Bug fix: Support string variable ids while setting expression
1 parent 593ffe2 commit 7107cfe

File tree

8 files changed

+23
-19
lines changed

8 files changed

+23
-19
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,4 @@
55
*.user
66
*.config
77
/tests
8+
/.vs

demo/index.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo/index.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,16 +45,16 @@ $(function () {
4545
$('#txt2').expressionBuilder({
4646
variables: [
4747
{
48-
variableId: 1,
48+
variableId: "v1",
4949
name: 'FirstName'
5050
},
5151
{
52-
variableId: 2,
52+
variableId: "v2",
5353
name: 'LastName'
5454
}
5555
],
5656
suggestions: "up",
57-
expression: "[2] + 35"
57+
expression: "[v2] + 35"
5858
});
5959

6060
$('#txt').keypress(function () {

src/expression-builder-v2.js

Lines changed: 8 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/expression-builder-v2.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/expression-builder-v2.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
/// <reference path="jquery.d.ts" />
44

55
interface ExpressionBuilderVariable {
6-
variableId: number,
6+
variableId: number | string,
77
name: string,
88
value?: any
99
}
@@ -827,7 +827,7 @@ jQuery.fn.extend({
827827
}
828828

829829
if (input == ']' && inVariable) {
830-
let varName = getVariableById(parseInt(varId));
830+
let varName = getVariableById(varId);
831831

832832
if (varName) {
833833
if (isNumber(varName[0]))
@@ -853,9 +853,9 @@ jQuery.fn.extend({
853853
return exp;
854854
}
855855

856-
function getVariableById(varId: number): string {
856+
function getVariableById(varId: number | string): string {
857857
for (var i = 0; i < options.variables.length; i++)
858-
if (options.variables[i].variableId == varId)
858+
if (options.variables[i].variableId === varId)
859859
return options.variables[i].name;
860860

861861
return undefined;
@@ -1065,7 +1065,7 @@ jQuery.fn.extend({
10651065
return expressionInput.val();
10661066
},
10671067

1068-
getVariableById: function (variableId: number) {
1068+
getVariableById: function (variableId: number | string) {
10691069
return getVariableById(variableId);
10701070
},
10711071

src/expression-builder.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)