-
-
Notifications
You must be signed in to change notification settings - Fork 203
Added gallery tab for eQSL cards #3318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a gallery view feature to the eQSL cards interface, allowing users to browse their QSL cards as visual thumbnails in addition to the existing list view. The implementation creates a tabbed interface with automatic thumbnail generation using PHP's GD library.
Key changes:
- Added Bootstrap tab navigation for switching between List and Gallery views
- Implemented automatic thumbnail generation with caching for performance
- Added responsive CSS grid layout for the gallery with hover effects
Comments suppressed due to low confidence (1)
application/views/eqslcard/index.php:153
- The output is not properly escaped for HTML context. Use
htmlspecialchars()or similar escaping functions to prevent XSS vulnerabilities.
echo '<a href="#" onclick="viewEqsl(\''.$qsl->image_file.'\', \''. $qsl->COL_CALL . '\')" class="photo" style="background-image: url(/'.$dest.');"></a>';
|
Thanks for the PR @stevendodd if you would consider some of the PR feedback both from myself and the automated copilot feedback |
Not sure how to handle the scrips/css do you have any suggestions? |
|
Obviously, this code could be extended to also provide a gallery for SSTV/QSO images as well, I didn't want to go too far without feedback |
Usually they live in assets folder should just be able to place them under each, you will find in footer.php lots of JS scripts are called along with header.php its looking good |
Yes, I found it and addressed all the issues. It should be good to merge. |
|
@magicbug it would be good to get this functionality live. Is there anything outstanding? |
Added gallery tab with automatically generated thumbnails onclick brings up the full card as per the view button from the list. Requires phpX.X-gd
sudo apt-get install php8.1-gd.New Tab Screenshot
Gallery Tab Screenshot
Onclick popup Screenshot