Skip to content

Conversation

@stevendodd
Copy link
Contributor

Added gallery tab with automatically generated thumbnails onclick brings up the full card as per the view button from the list. Requires phpX.X-gd sudo apt-get install php8.1-gd.

New Tab Screenshot

New Tab Screenshot

Gallery Tab Screenshot

Gallery Tab Screenshot

Onclick popup Screenshot

Onclick popup Screenshot

@magicbug magicbug requested review from Copilot and magicbug August 10, 2025 13:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a gallery view feature to the eQSL cards interface, allowing users to browse their QSL cards as visual thumbnails in addition to the existing list view. The implementation creates a tabbed interface with automatic thumbnail generation using PHP's GD library.

Key changes:

  • Added Bootstrap tab navigation for switching between List and Gallery views
  • Implemented automatic thumbnail generation with caching for performance
  • Added responsive CSS grid layout for the gallery with hover effects
Comments suppressed due to low confidence (1)

application/views/eqslcard/index.php:153

  • The output is not properly escaped for HTML context. Use htmlspecialchars() or similar escaping functions to prevent XSS vulnerabilities.
				 echo '<a href="#" onclick="viewEqsl(\''.$qsl->image_file.'\', \''. $qsl->COL_CALL . '\')" class="photo" style="background-image: url(/'.$dest.');"></a>';

@magicbug
Copy link
Owner

Thanks for the PR @stevendodd if you would consider some of the PR feedback both from myself and the automated copilot feedback

@stevendodd
Copy link
Contributor Author

Thanks for the PR @stevendodd if you would consider some of the PR feedback both from myself and the automated copilot feedback

Not sure how to handle the scrips/css do you have any suggestions?

@stevendodd
Copy link
Contributor Author

Obviously, this code could be extended to also provide a gallery for SSTV/QSO images as well, I didn't want to go too far without feedback

@magicbug
Copy link
Owner

Thanks for the PR @stevendodd if you would consider some of the PR feedback both from myself and the automated copilot feedback

Not sure how to handle the scrips/css do you have any suggestions?

Usually they live in assets folder should just be able to place them under each, you will find in footer.php lots of JS scripts are called along with header.php its looking good

@stevendodd
Copy link
Contributor Author

Thanks for the PR @stevendodd if you would consider some of the PR feedback both from myself and the automated copilot feedback

Not sure how to handle the scrips/css do you have any suggestions?

Usually they live in assets folder should just be able to place them under each, you will find in footer.php lots of JS scripts are called along with header.php its looking good

Yes, I found it and addressed all the issues. It should be good to merge.

@stevendodd
Copy link
Contributor Author

@magicbug it would be good to get this functionality live. Is there anything outstanding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants