Skip to content

feat: improve navbar responsiveness across all device sizes#1306

Open
Pranav-IIITM wants to merge 1 commit into
magic-peach:mainfrom
Pranav-IIITM:feat/navbar-responsiveness
Open

feat: improve navbar responsiveness across all device sizes#1306
Pranav-IIITM wants to merge 1 commit into
magic-peach:mainfrom
Pranav-IIITM:feat/navbar-responsiveness

Conversation

@Pranav-IIITM

Copy link
Copy Markdown
Contributor

Description

Improves navbar responsiveness across all device sizes. Updated internal navigation links in the mobile menu to use Next.js <Link> component instead of raw <a> tags, fixing ESLint (@next/next/no-html-link-for-pages) errors and ensuring correct client-side routing. The navbar now adapts cleanly across desktop, tablet, and mobile (down to 320px width) with proper spacing, alignment, and no overflow issues.

PR Summary

  • Added a responsive Header component at Header.tsx
  • Replaced the old inline header in layout.tsx with the new component
  • Added a mobile hamburger menu button (aria-label="Toggle menu") visible on small screens and hidden on md+
  • Hid nav links on mobile and kept them available in a mobile drawer, while preserving desktop layout
  • Used Tailwind responsive classes only (px-4, sm:px-6, md:hidden, etc.)
  • Updated page.tsx so the "⭐ Star on GitHub" button only appears on md+ screens to avoid overlap
  • Ensured no new dependencies, no component rewrites beyond the header refactor, and no raw CSS was added

This improves navbar responsiveness from 320px upward while keeping the existing design intact.


Related Issue

Closes #1295


Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • GSSoC contribution

Participant Info

  • GitHub username: @Pranav-IIITM
  • Contribution level (Beginner/Intermediate/Advanced): Intermediate

Screen Recording

Recording.2026-05-27.232641.1.mp4

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel

vercel Bot commented May 27, 2026

Copy link
Copy Markdown

@Pranav-IIITM is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @Pranav-IIITM

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @Pranav-IIITM!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor gssoc'26 GirlScript Summer of Code 2026 labels May 27, 2026
@Pranav-IIITM Pranav-IIITM changed the title feat: improve navbar responsiveness across all screen sizes feat: improve navbar responsiveness across all device sizes May 27, 2026
@Pranav-IIITM

Copy link
Copy Markdown
Contributor Author

@magic-peach Please review the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:intermediate Intermediate level - 35 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] : Improve navbar responsiveness across all devices

1 participant