-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue] Remove forbidden @author
tag from Magento_Wishlist
#37243
Comments
Hi @engcom-Bravo. Thank you for working on this issue.
|
Hello @fredden, Thanks for the report and collaboration! We can see the PR related to this GitHub issue contains the improvement in the DocBlock as mentioned in the below documentation: https://developer.adobe.com/commerce/php/coding-standards/docblock/#structure-of-documentation-space
Hence confirming this issue for further processing. Thanks |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-8377 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue. |
This issue is automatically created based on existing pull request: #36978: Remove forbidden
@author
tag fromMagento_Wishlist
Description
According to https://devdocs.magento.com/guides/v2.4/coding-standards/docblock-standard-general.html#documentation-space, the
@author
tag is not permitted in Magento. This pull request removes this tag from theMagento_Wishlist
module. Given there are so many instances of this tag, I've opened a small pull request to get the process started. I expect that the linter will force me to fix several other coding standards violations on the way, so having a smaller pull request means that task is easier to manage. I plan to open more pull requests to tackle the other instances of this tag.See also magento/magento-coding-standard#382 and magento/magento-coding-standard#167
See also #36304, #36976, #36977
Manual testing scenarios
There are not code changes in this pull request. This pull request only removes forbidden comments.
Contribution checklist
The text was updated successfully, but these errors were encountered: