Skip to content

Commit a89d82f

Browse files
slavvkaslavvka
authored
Merge pull request #1343 from magento-performance/pr-2.2
Fixed issues: - MAGETWO-67240 Duplicate and broken products appear after import - MAGETWO-70716 Provide entity manager description - MAGETWO-70406 Significant degradation of CatalogPermissions indexer with big number of customer groups
2 parents 495d0c4 + 75c41cc commit a89d82f

File tree

20 files changed

+442
-318
lines changed

20 files changed

+442
-318
lines changed

‎app/code/Magento/BundleImportExport/Model/Import/Product/Type/Bundle.php‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
use \Magento\Framework\App\ObjectManager;
1212
use \Magento\Bundle\Model\Product\Price as BundlePrice;
1313
use \Magento\Catalog\Model\Product\Type\AbstractType;
14+
use Magento\CatalogImportExport\Model\Import\Product;
1415

1516
/**
1617
* Class Bundle
@@ -173,7 +174,7 @@ protected function parseSelections($rowData, $entityId)
173174
$rowData['bundle_values']
174175
);
175176
$selections = explode(
176-
\Magento\CatalogImportExport\Model\Import\Product::PSEUDO_MULTI_LINE_SEPARATOR,
177+
Product::PSEUDO_MULTI_LINE_SEPARATOR,
177178
$rowData['bundle_values']
178179
);
179180
foreach ($selections as $selection) {
@@ -343,7 +344,7 @@ public function saveData()
343344
$newSku = $this->_entityModel->getNewSku();
344345
while ($bunch = $this->_entityModel->getNextBunch()) {
345346
foreach ($bunch as $rowNum => $rowData) {
346-
$productData = $newSku[$rowData[\Magento\CatalogImportExport\Model\Import\Product::COL_SKU]];
347+
$productData = $newSku[strtolower($rowData[Product::COL_SKU])];
347348
$productIds[] = $productData[$this->getProductEntityLinkField()];
348349
}
349350
$this->deleteOptionsAndSelections($productIds);
@@ -355,7 +356,7 @@ public function saveData()
355356
if (!$this->_entityModel->isRowAllowedToImport($rowData, $rowNum)) {
356357
continue;
357358
}
358-
$productData = $newSku[$rowData[\Magento\CatalogImportExport\Model\Import\Product::COL_SKU]];
359+
$productData = $newSku[strtolower($rowData[Product::COL_SKU])];
359360
if ($this->_type != $productData['type_id']) {
360361
continue;
361362
}

‎app/code/Magento/BundleImportExport/Test/Unit/Model/Import/Product/Type/BundleTest.php‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,11 @@ public function testSaveDataProvider()
299299
'bunch' => ['bundle_values' => 'value1', 'sku' => 'sku', 'name' => 'name'],
300300
'allowImport' => true
301301
],
302+
[
303+
'skus' => ['newSku' => ['sku' => ['sku' => 'SKU', 'entity_id' => 3, 'type_id' => 'bundle']]],
304+
'bunch' => ['bundle_values' => 'value1', 'sku' => 'SKU', 'name' => 'name'],
305+
'allowImport' => true
306+
],
302307
[
303308
'skus' => ['newSku' => ['sku' => ['sku' => 'sku', 'entity_id' => 3, 'type_id' => 'simple']]],
304309
'bunch' => ['bundle_values' => 'value1', 'sku' => 'sku', 'name' => 'name'],

‎app/code/Magento/CatalogImportExport/Model/Import/Product.php‎

Lines changed: 89 additions & 70 deletions
Large diffs are not rendered by default.

‎app/code/Magento/CatalogImportExport/Model/Import/Product/SkuProcessor.php‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ public function reloadOldSkus()
113113
*/
114114
public function addNewSku($sku, $data)
115115
{
116+
$sku = strtolower($sku);
116117
$this->newSkus[$sku] = $data;
117118
return $this;
118119
}
@@ -125,6 +126,7 @@ public function addNewSku($sku, $data)
125126
*/
126127
public function setNewSkuData($sku, $key, $data)
127128
{
129+
$sku = strtolower($sku);
128130
if (isset($this->newSkus[$sku])) {
129131
$this->newSkus[$sku][$key] = $data;
130132
}
@@ -138,6 +140,7 @@ public function setNewSkuData($sku, $key, $data)
138140
public function getNewSku($sku = null)
139141
{
140142
if ($sku !== null) {
143+
$sku = strtolower($sku);
141144
return isset($this->newSkus[$sku]) ? $this->newSkus[$sku] : null;
142145
}
143146
return $this->newSkus;
@@ -157,7 +160,7 @@ protected function _getSkus()
157160
}
158161
foreach ($this->productFactory->create()->getProductEntitiesInfo($columns) as $info) {
159162
$typeId = $info['type_id'];
160-
$sku = $info['sku'];
163+
$sku = strtolower($info['sku']);
161164
$oldSkus[$sku] = [
162165
'type_id' => $typeId,
163166
'attr_set_id' => $info['attribute_set_id'],

‎app/code/Magento/CatalogImportExport/Model/Import/Product/Validator/SuperProductsSku.php‎

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,20 @@
66
namespace Magento\CatalogImportExport\Model\Import\Product\Validator;
77

88
use Magento\CatalogImportExport\Model\Import\Product\RowValidatorInterface;
9+
use Magento\CatalogImportExport\Model\Import\Product\SkuProcessor;
910

1011
class SuperProductsSku extends AbstractImportValidator implements RowValidatorInterface
1112
{
1213
/**
13-
* @var \Magento\CatalogImportExport\Model\Import\Product\SkuProcessor
14+
* @var SkuProcessor
1415
*/
1516
protected $skuProcessor;
1617

1718
/**
18-
* @param \Magento\CatalogImportExport\Model\Import\Product\SkuProcessor $skuProcessor
19+
* @param SkuProcessor $skuProcessor
1920
*/
2021
public function __construct(
21-
\Magento\CatalogImportExport\Model\Import\Product\SkuProcessor $skuProcessor
22+
SkuProcessor $skuProcessor
2223
) {
2324
$this->skuProcessor = $skuProcessor;
2425
}
@@ -30,13 +31,14 @@ public function isValid($value)
3031
{
3132
$this->_clearMessages();
3233
$oldSku = $this->skuProcessor->getOldSkus();
33-
if (!empty($value['_super_products_sku']) && (!isset(
34-
$oldSku[$value['_super_products_sku']]
35-
) && $this->skuProcessor->getNewSku($value['_super_products_sku']) === null
36-
)
37-
) {
38-
$this->_addMessages([self::ERROR_SUPER_PRODUCTS_SKU_NOT_FOUND]);
39-
return false;
34+
if (!empty($value['_super_products_sku'])) {
35+
$superSku = strtolower($value['_super_products_sku']);
36+
if (!isset($oldSku[$superSku])
37+
&& $this->skuProcessor->getNewSku($superSku) === null
38+
) {
39+
$this->_addMessages([self::ERROR_SUPER_PRODUCTS_SKU_NOT_FOUND]);
40+
return false;
41+
}
4042
}
4143
return true;
4244
}

‎app/code/Magento/CatalogImportExport/Test/Unit/Model/Import/Product/Validator/SuperProductsSkuTest.php‎

Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
<?php
2+
/**
3+
* Copyright © Magento, Inc. All rights reserved.
4+
* See COPYING.txt for license details.
5+
*/
6+
namespace Magento\CatalogImportExport\Test\Unit\Model\Import\Product\Validator;
7+
8+
use Magento\CatalogImportExport\Model\Import\Product\SkuProcessor;
9+
use Magento\CatalogImportExport\Model\Import\Product\Validator\SuperProductsSku;
10+
use PHPUnit_Framework_MockObject_MockObject as Mock;
11+
12+
/**
13+
* Test for SuperProductsSku
14+
*
15+
* @see SuperProductsSku
16+
*/
17+
class SuperProductsSkuTest extends \PHPUnit_Framework_TestCase
18+
{
19+
/**
20+
* @var SkuProcessor|Mock
21+
*/
22+
private $skuProcessorMock;
23+
24+
/**
25+
* @var SuperProductsSku
26+
*/
27+
private $model;
28+
29+
protected function setUp()
30+
{
31+
$this->skuProcessorMock = $this->getMockBuilder(SkuProcessor::class)
32+
->disableOriginalConstructor()
33+
->getMock();
34+
35+
$this->model = new SuperProductsSku($this->skuProcessorMock);
36+
}
37+
38+
/**
39+
* @param array $value
40+
* @param array $oldSkus
41+
* @param bool $hasNewSku
42+
* @param bool $expectedResult
43+
* @dataProvider isValidDataProvider
44+
*/
45+
public function testIsValid(array $value, array $oldSkus, $hasNewSku = false, $expectedResult = true)
46+
{
47+
$this->skuProcessorMock->expects($this->once())
48+
->method('getOldSkus')
49+
->willReturn($oldSkus);
50+
51+
if ($hasNewSku) {
52+
$this->skuProcessorMock->expects($this->once())
53+
->method('getNewSku')
54+
->willReturn('someNewSku');
55+
}
56+
57+
$this->assertEquals($expectedResult, $this->model->isValid($value));
58+
}
59+
60+
/**
61+
* @return array
62+
*/
63+
public function isValidDataProvider()
64+
{
65+
return [
66+
[
67+
[],
68+
[],
69+
],
70+
[
71+
[],
72+
['sku1' => []]
73+
],
74+
[
75+
['_super_products_sku' => 'SKU1'],
76+
['sku2' => []],
77+
false,
78+
false
79+
],
80+
[
81+
['_super_products_sku' => 'SKU1'],
82+
['sku2' => []],
83+
true,
84+
true
85+
],
86+
[
87+
['_super_products_sku' => 'SKU1'],
88+
['sku1' => []],
89+
false,
90+
true
91+
],
92+
];
93+
}
94+
}

‎app/code/Magento/CatalogImportExport/Test/Unit/Model/Import/ProductTest.php‎

Lines changed: 2 additions & 140 deletions
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@ protected function _initSkus()
516516
{
517517
$this->skuProcessor->expects($this->once())->method('setTypeModels');
518518
$this->skuProcessor->expects($this->once())->method('reloadOldSkus')->willReturnSelf();
519-
$this->skuProcessor->expects($this->once())->method('getOldSkus');
519+
$this->skuProcessor->expects($this->once())->method('getOldSkus')->willReturn([]);
520520
return $this;
521521
}
522522

@@ -967,44 +967,6 @@ public function testValidateRowValidateExistingProductTypeAddErrorRowCall()
967967
$importProduct->validateRow($rowData, $rowNum);
968968
}
969969

970-
public function testValidateRowValidateExistingProductTypeResetSku()
971-
{
972-
$sku = 'sku';
973-
$rowNum = 0;
974-
$rowData = [
975-
\Magento\CatalogImportExport\Model\Import\Product::COL_SKU => $sku,
976-
];
977-
$oldSku = [
978-
$sku => [
979-
'type_id' => 'type_id_val',
980-
],
981-
];
982-
$importProduct = $this->createModelMockWithErrorAggregator(['getOptionEntity']);
983-
984-
$this->setPropertyValue($importProduct, '_oldSku', $oldSku);
985-
986-
//suppress option validation
987-
$this->_rewriteGetOptionEntityInImportProduct($importProduct);
988-
//suppress validator
989-
$this->_setValidatorMockInImportProduct($importProduct);
990-
991-
$expectedSku = false;
992-
$newSku = [
993-
'attr_set_code' => 'new_attr_set_code',
994-
'type_id' => 'new_type_id_val',
995-
];
996-
$this->skuProcessor->expects($this->once())->method('getNewSku')->with($expectedSku)->willReturn($newSku);
997-
$this->setPropertyValue($importProduct, 'skuProcessor', $this->skuProcessor);
998-
$productType = $this->getMockBuilder(\Magento\CatalogImportExport\Model\Import\Product\Type\AbstractType::class)
999-
->disableOriginalConstructor()
1000-
->getMock();
1001-
$this->setPropertyValue($importProduct, '_productTypeModels', [
1002-
$newSku['type_id'] => $productType
1003-
]);
1004-
1005-
$importProduct->validateRow($rowData, $rowNum);
1006-
}
1007-
1008970
/**
1009971
* @dataProvider validateRowValidateNewProductTypeAddRowErrorCallDataProvider
1010972
*/
@@ -1094,113 +1056,13 @@ public function testValidateRowValidateNewProductTypeGetNewSkuCall()
10941056
$importProduct->validateRow($rowData, $rowNum);
10951057
}
10961058

1097-
public function testValidateRowValidateNewProductTypeResetSku()
1098-
{
1099-
$sku = 'sku';
1100-
$rowNum = 0;
1101-
$rowData = [
1102-
\Magento\CatalogImportExport\Model\Import\Product::COL_SKU => $sku,
1103-
\Magento\CatalogImportExport\Model\Import\Product::COL_TYPE => 'value',
1104-
\Magento\CatalogImportExport\Model\Import\Product::COL_ATTR_SET => 'value',
1105-
];
1106-
1107-
$oldSku = [
1108-
$sku => [
1109-
'type_id' => 'type_id_val',
1110-
],
1111-
];
1112-
$_productTypeModels = [
1113-
$rowData[\Magento\CatalogImportExport\Model\Import\Product::COL_TYPE] => 'value',
1114-
];
1115-
$_attrSetNameToId = [
1116-
$rowData[\Magento\CatalogImportExport\Model\Import\Product::COL_ATTR_SET] => 'attr_set_code_val'
1117-
];
1118-
1119-
$importProduct = $this->createModelMockWithErrorAggregator(
1120-
['addRowError', 'getOptionEntity'],
1121-
['isRowInvalid' => false]
1122-
);
1123-
1124-
$this->setPropertyValue($importProduct, '_oldSku', $oldSku);
1125-
$this->setPropertyValue($importProduct, '_productTypeModels', $_productTypeModels);
1126-
$this->setPropertyValue($importProduct, '_attrSetNameToId', $_attrSetNameToId);
1127-
1128-
$this->_rewriteGetOptionEntityInImportProduct($importProduct);//suppress option validation
1129-
$this->_setValidatorMockInImportProduct($importProduct);//suppress validator
1130-
1131-
$expectedSku = false;
1132-
$newSku = [
1133-
'attr_set_code' => 'new_attr_set_code',
1134-
'type_id' => 'new_type_id_val',
1135-
];
1136-
$this->skuProcessor->expects($this->once())->method('getNewSku')->with($expectedSku)->willReturn($newSku);
1137-
$this->setPropertyValue($importProduct, 'skuProcessor', $this->skuProcessor);
1138-
$productType = $this->getMockBuilder(\Magento\CatalogImportExport\Model\Import\Product\Type\AbstractType::class)
1139-
->disableOriginalConstructor()
1140-
->getMock();
1141-
$this->setPropertyValue($importProduct, '_productTypeModels', [
1142-
$newSku['type_id'] => $productType
1143-
]);
1144-
1145-
$importProduct->validateRow($rowData, $rowNum);
1146-
}
1147-
11481059
public function testValidateDefaultScopeNotValidAttributesResetSku()
11491060
{
1150-
$sku = 'sku';
1151-
$rowNum = 0;
1152-
$attrCode = 'code';
1153-
$stringUtilsMock = $this->getMockBuilder(\Magento\Framework\Stdlib\StringUtils::class)
1154-
->setMethods(null)
1155-
->getMock();
1156-
$this->setPropertyValue($this->importProduct, 'string', $stringUtilsMock);
1157-
1158-
$scopeMock = $this->getMock(
1159-
\Magento\CatalogImportExport\Model\Import\Product::class,
1160-
['getRowScope'],
1161-
[],
1162-
'',
1163-
false
1164-
);
1165-
1166-
$colStore = \Magento\CatalogImportExport\Model\Import\Product::COL_STORE;
1167-
$scopeRowData = [
1168-
$sku => 'sku',
1169-
$colStore => null,
1170-
];
1171-
$scopeResult = \Magento\CatalogImportExport\Model\Import\Product::SCOPE_DEFAULT;
1172-
$scopeMock->expects($this->any())->method('getRowScope')->with($scopeRowData)->willReturn($scopeResult);
1173-
$oldSku = [
1174-
$sku => [
1175-
'type_id' => 'type_id_val',
1176-
],
1177-
];
1178-
1179-
$this->setPropertyValue($this->importProduct, '_oldSku', $oldSku);
1180-
1181-
$expectedSku = false;
1182-
$newSku = [
1183-
'attr_set_code' => 'new_attr_set_code',
1184-
'type_id' => 'new_type_id_val',
1185-
];
1186-
$this->skuProcessor->expects($this->any())->method('getNewSku')->with($expectedSku)->willReturn($newSku);
1187-
$this->setPropertyValue($this->importProduct, 'skuProcessor', $this->skuProcessor);
1188-
1189-
$attrParams = [
1190-
'type' => 'varchar',
1191-
];
1192-
$attrRowData = [
1193-
'code' => str_repeat(
1194-
'a',
1195-
\Magento\CatalogImportExport\Model\Import\Product::DB_MAX_VARCHAR_LENGTH + 1
1196-
),
1197-
];
1198-
11991061
$this->validator->expects($this->once())->method('isAttributeValid')->willReturn(false);
12001062
$messages = ['validator message'];
12011063
$this->validator->expects($this->once())->method('getMessages')->willReturn($messages);
12021064

1203-
$result = $this->importProduct->isAttributeValid($attrCode, $attrParams, $attrRowData, $rowNum);
1065+
$result = $this->importProduct->isAttributeValid('code', ['attribute params'], ['row data'], 1);
12041066
$this->assertFalse($result);
12051067
}
12061068

0 commit comments

Comments
 (0)