From c9ed5a23307d5231100f71cba24ba2638c3e800f Mon Sep 17 00:00:00 2001 From: Shivam7-1 <55046031+Shivam7-1@users.noreply.github.com> Date: Wed, 8 Jan 2025 12:28:08 +0530 Subject: [PATCH 1/3] Update live-edit.ts --- .../PageBuilder/view/adminhtml/web/ts/js/binding/live-edit.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/binding/live-edit.ts b/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/binding/live-edit.ts index 2d6a5d63485..2728f301d6f 100644 --- a/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/binding/live-edit.ts +++ b/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/binding/live-edit.ts @@ -33,8 +33,8 @@ function stripHtml(html: string) { * @param {Element} element */ function handlePlaceholderClass(element: Element) { - if (stripHtml(element.innerHTML).length === 0) { - element.innerHTML = ""; + if (stripHtml(element.innerText).length === 0) { + element.innerText = ""; element.classList.add("placeholder-text"); } else { element.classList.remove("placeholder-text"); From 7e2b50f0a49bd74beba0640ca750e7a91b762b04 Mon Sep 17 00:00:00 2001 From: Shivam7-1 <55046031+Shivam7-1@users.noreply.github.com> Date: Fri, 10 Jan 2025 17:47:40 +0530 Subject: [PATCH 2/3] Update-1 live-edit.ts --- .../PageBuilder/view/adminhtml/web/ts/js/binding/live-edit.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/binding/live-edit.ts b/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/binding/live-edit.ts index 2728f301d6f..488acb522b7 100644 --- a/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/binding/live-edit.ts +++ b/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/binding/live-edit.ts @@ -33,8 +33,8 @@ function stripHtml(html: string) { * @param {Element} element */ function handlePlaceholderClass(element: Element) { - if (stripHtml(element.innerText).length === 0) { - element.innerText = ""; + if (stripHtml(element.textContent).length === 0) { + element.textContent = ""; element.classList.add("placeholder-text"); } else { element.classList.remove("placeholder-text"); From 7e41f5c7fcd39f74283edf8a7a87a015735b51de Mon Sep 17 00:00:00 2001 From: Shivam7-1 <55046031+Shivam7-1@users.noreply.github.com> Date: Mon, 13 Jan 2025 17:35:20 +0530 Subject: [PATCH 3/3] Removed use of stripHtml --- .../PageBuilder/view/adminhtml/web/ts/js/binding/live-edit.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/binding/live-edit.ts b/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/binding/live-edit.ts index 488acb522b7..45651566398 100644 --- a/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/binding/live-edit.ts +++ b/app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/binding/live-edit.ts @@ -33,14 +33,13 @@ function stripHtml(html: string) { * @param {Element} element */ function handlePlaceholderClass(element: Element) { - if (stripHtml(element.textContent).length === 0) { + if (element.textContent.length === 0) { element.textContent = ""; element.classList.add("placeholder-text"); } else { element.classList.remove("placeholder-text"); } } - // Custom Knockout binding for live editing text inputs ko.bindingHandlers.liveEdit = {