Created Unit Test for array autovivification sniff

Author: anzin

Diff for: Magento2/Sniffs/PHP/ArrayAutovivificationSniff.php

@@ -48,12 +48,15 @@ public function process(File $phpcsFile, $stackPtr): void
 
         if ($positionSquareBracket) {
             $tokens = $phpcsFile->getTokens();
-            $propertyTokenKey = array_keys(array_column($tokens, 'content'), $tokens[$stackPtr]['content']);
+            $positionFunction = $phpcsFile->findPrevious(T_FUNCTION, $positionSquareBracket) ?: 0;
+            $sliceLength = $stackPtr - $positionFunction;
+            $sliceToken = array_slice(array_column($tokens, 'content'), $positionFunction, $sliceLength, true);
+            $propertyTokenKey = array_keys($sliceToken, $tokens[$stackPtr]['content']);
 
             arsort($propertyTokenKey);
 
             foreach ($propertyTokenKey as $tokenKey) {
-                if ($tokenKey < $stackPtr && $tokens[$tokenKey + 2]['content'] === '=') {
+                if ($tokens[$tokenKey + 2]['content'] === '=') {
                     if ($tokens[$tokenKey + 4]['content'] != 'false') {
                         return;
                     }

Diff for: Magento2/Tests/PHP/ArrayAutovivificationUnitTest.inc

@@ -0,0 +1,60 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento2\Tests\PHP;
+
+/**
+ * Class to test array avtovivification.
+ */
+class Avtovivification
+{
+    /**
+     * @return array
+     */
+    public function testNullAvtovivification()
+    {
+        $productIds = null;
+
+        $productIds[] = 'test_array_value';
+
+        return $productIds;
+    }
+
+    /**
+     * @return array
+     */
+    public function testArrayAvtovivification()
+    {
+        $productIds = [];
+
+        $productIds[] = 'test_array_value';
+
+        return $productIds;
+    }
+
+    /**
+     * @return array
+     */
+    public function testFalseAvtovivification()
+    {
+        $productIds = false;
+
+        $productIds[] = 'test_array_value';
+
+        return $productIds;
+    }
+
+    /**
+     * @return array
+     */
+    public function testUndefineAvtovivification()
+    {
+        $productIds[] = 'test_array_value';
+
+        return $productIds;
+    }
+}

Diff for: Magento2/Tests/PHP/ArrayAutovivificationUnitTest.php

@@ -0,0 +1,35 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento2\Tests\PHP;
+
+use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;
+
+class ArrayAutovivificationUnitTest extends AbstractSniffUnitTest
+{
+    /**
+     * @inheritdoc
+     */
+    public function getErrorList(): array
+    {
+        return [];
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getWarningList($testFile = ''): array
+    {
+        if ($testFile === 'ArrayAutovivificationUnitTest.inc') {
+            return [
+                46 => 1
+            ];
+        }
+
+        return [];
+    }
+}

Diff for: Magento2/ruleset.xml

@@ -400,6 +400,11 @@
         <type>warning</type>
         <exclude-pattern>*\.xml$</exclude-pattern>
     </rule>
+    <rule ref="Magento2.PHP.ArrayAutovivification">
+        <severity>7</severity>
+        <type>warning</type>
+        <exclude-pattern>*\.xml$</exclude-pattern>
+    </rule>
     <rule ref="Magento2.Performance.ForeachArrayMerge">
         <severity>7</severity>
         <type>warning</type>