Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI locks up when controlling a player #12275

Closed
PurpleCrowbar opened this issue May 22, 2024 · 4 comments
Closed

AI locks up when controlling a player #12275

PurpleCrowbar opened this issue May 22, 2024 · 4 comments
Labels
AI bug Bugs and errors

Comments

@PurpleCrowbar
Copy link
Member

When an AI would take control of a player, for example due to the effect of [[Emrakul, the Promised End]], they take no actions when controlling that player until their timer entirely runs out, regardless of AI skill level. This bug was reported in a comment on #2088, but was not made its own issue for some reason.

Copy link

Emrakul, the Promised End - (Gatherer) (Scryfall) (EDHREC)

{13}
Legendary Creature — Eldrazi
13/13
This spell costs {1} less to cast for each card type among cards in your graveyard.
When you cast this spell, you gain control of target opponent during that player's next turn. After that turn, that player takes an extra turn.
Flying, trample, protection from instants

@Susucre
Copy link
Contributor

Susucre commented May 22, 2024

Of note, it is also broken for human players. Might not be entirely the AI's code fault but there might be some shared issue on how control change is handled by game engine.

#12192

@JayDi85 JayDi85 added AI bug Bugs and errors labels May 22, 2024
@JayDi85
Copy link
Member

JayDi85 commented May 22, 2024

AI do not use HumanPlayer code -- it's two different problems.

HumanPlayer has many miss places with wrong player usage, see TODO list with examples:

shot_240522_211205

they take no actions when controlling that player until their timer entirely runs out, regardless of AI skill level

Yes, it looks like a game freeze due priority or active player lost. Can /fix chat command to fix it?

@JayDi85
Copy link
Member

JayDi85 commented Jan 11, 2025

Game freezes with AI fixed in #12878, potential AI implementation left in #13220

P.S. Game engine do not support real control changing — that’s all implemented in upper layer (inside human/network and computer implementations).

@JayDi85 JayDi85 closed this as completed Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI bug Bugs and errors
Projects
None yet
Development

No branches or pull requests

3 participants