Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pandas import from sql module #381

Closed
machow opened this issue Jan 20, 2022 · 1 comment
Closed

remove pandas import from sql module #381

machow opened this issue Jan 20, 2022 · 1 comment
Milestone
tidyselection ref...

Comments

@machow
Copy link
Owner

machow commented Jan 20, 2022 •
edited
Loading

Currently, siuba's module dependencies look roughly like...

image

This looks pretty good, except we have to import pandas into sql.py, in order to run tidy selection. The use of pandas series in tidyselection is pretty trivial, so refactoring tidyselection (#365) is a good chance to move it out.
@machow machow added this to the tidyselection refactor milestone Jan 20, 2022
@machow machow added this to siuba Jan 20, 2022
@machow machow moved this to Backlog in siuba Jan 22, 2022
@machow
Copy link
Owner Author

machow commented Mar 23, 2022

Mentioned in #71, let's track there

@machow machow closed this as completed Mar 23, 2022
Repository owner moved this from Backlog to Done in siuba Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
siuba
Status: Done
Milestone
tidyselection refactor
Development

No branches or pull requests
1 participant
@machow