Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional test coverage and compatibility tests #82

Open
bnewbold opened this issue Oct 13, 2022 · 0 comments
Open

Additional test coverage and compatibility tests #82

bnewbold opened this issue Oct 13, 2022 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@bnewbold
Copy link
Member

More test coverage, generically, would be great. In particular, corner cases of the (de)serialization process, and more complex 3rd-party macaroon situations.

There are two sources of existing compatibility tests which could easily be added.

The first are the test vector files from the libmacaroons C library. We would need a simple test harness to load these files, attempt verification, and check that the result matches what is recorded in the test vector file.

The second is the set of tests in the macarooncompat project. We could try to integrate in to that repository, or manually look through the tests and port them back to this repo.

@bnewbold bnewbold added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant