Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence NXDOMAIN event error messages #12

Closed
m3047 opened this issue Nov 27, 2024 · 2 comments
Closed

Silence NXDOMAIN event error messages #12

m3047 opened this issue Nov 27, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@m3047
Copy link
Owner

m3047 commented Nov 27, 2024

The correct approach to handling NXDOMAIN responses is to check that the response status is NOERROR and (silently) discard otherwise.

Current observed behavior is to log errors which look like: ERROR:root:Telemetry: KeyError: 'address'.
@m3047 m3047 pinned this issue Nov 27, 2024
@m3047 m3047 added the enhancement New feature or request label Nov 27, 2024
@m3047 m3047 changed the title Silence NXDOMAIN even error messages Silence NXDOMAIN event error messages Nov 27, 2024
@m3047
Copy link
Owner Author

m3047 commented Nov 27, 2024

Enhancement / fix is on the fwm branch.

@m3047 m3047 mentioned this issue Nov 28, 2024
Closed
@m3047
Copy link
Owner Author

m3047 commented Nov 28, 2024

Fix is on main at ce79ad1.

This is a minor fix, you should apply it if you are consuming dnstap_agent telemetry in order to silence the error messages which you will observe if you upgrade ShoDoHFlo. See m3047/shodohflo#13

@m3047 m3047 closed this as completed Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m3047