Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overcoming obstacles in running program #4

Open
mortonjt opened this issue Jan 27, 2022 · 2 comments
Open

Overcoming obstacles in running program #4

mortonjt opened this issue Jan 27, 2022 · 2 comments

Comments

@mortonjt
Copy link

Hello, thank you for making this program available.

I was able to get your adversarial autoencoder working, but it did require quite a bit of modification do so, namely

  1. Modifying BaseData.getitem to np.int64 -- sample_x, sample_y -> sample_x, sample_y.astype(np.int64)
  2. Forcing the batch ids to be 1-based indexed - there were some really weird indexing errors popping up in _forward_autoencode when 0-based indexed batch ids (which is naturally outputted from sklearn.preprocessing.LabelEncoder).
  3. Removing preprocessing steps -- they weren't relevant for my data, since I already preprocessed them.

(1) looks like a bug to me - and having example datasets on the github repo to test NormAE would have been tremendously useful, since it would also help users validate their install. (2) could benefit from better documentation. (3) is probably un-necessary given how many different preprocessing procedures there are.

@luyiyun
Copy link
Owner

luyiyun commented Jan 27, 2022

Thanks for your advises. I will soon fix these problems.

@S-KD
Copy link

S-KD commented Apr 12, 2023

@luyiyun, I agree with @mortonjt please provide example datasets from your publication to test NormAE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants