Skip to content

Commit aedbd37

Browse files
do not stringify none return value (#148)
1 parent 4df8928 commit aedbd37

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

src/lumigo_tracer/spans_container.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,8 @@ def end(self, ret_val=None) -> Optional[int]:
260260
parsed_ret_val = None
261261
if Configuration.verbose:
262262
try:
263-
parsed_ret_val = lumigo_dumps(ret_val, enforce_jsonify=True, decimal_safe=True)
263+
if ret_val is not None:
264+
parsed_ret_val = lumigo_dumps(ret_val, enforce_jsonify=True, decimal_safe=True)
264265
except Exception as err:
265266
suffix = ""
266267
if err.args:

src/test/unit/test_spans_container.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,13 @@ def test_spans_container_not_send_start_span_on_send_only_on_errors_mode(monkeyp
3333
assert _is_start_span_sent() is False
3434

3535

36+
def test_spans_container_end_function_got_none_return_value(monkeypatch):
37+
SpansContainer.create_span()
38+
SpansContainer.get_span().start()
39+
SpansContainer.get_span().end(None)
40+
assert SpansContainer.get_span().function_span["return_value"] is None
41+
42+
3643
def test_spans_container_end_function_not_send_spans_on_send_only_on_errors_mode(
3744
monkeypatch, dummy_http_request
3845
):

0 commit comments

Comments
 (0)