Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.0: bats files and checkbashisms incompatibility #56

Open
jkroepke opened this issue Jul 21, 2022 · 0 comments
Open

0.5.0: bats files and checkbashisms incompatibility #56

jkroepke opened this issue Jul 21, 2022 · 0 comments

Comments

@jkroepke
Copy link
Contributor

Hi,

i'm running the action like this:

      - name: Run the sh-checker
        uses: luizm/[email protected]
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          SHELLCHECK_OPTS: -x
        with:
          sh_checker_comment: true
          sh_checker_exclude: "tests/assets tests/bats"
          sh_checker_checkbashisms_enable: true

on repo: https://github.com/jkroepke/helm-secrets

dependabot opens a PR to bump the action, which is currently failing: https://github.com/jkroepke/helm-secrets/runs/7444254384?check_suite_focus=true
And here is an output from main branch: https://github.com/jkroepke/helm-secrets/runs/7296253846?check_suite_focus=true

sh-checker is finding 47 shell scripts instead 31. It looks like the newer shfmt include the bats files from the repository.

Now checkbashisms is confused, since it throws errors like script tests/unit/view.bats does not appear to be a /bin/sh script; skipping and the action will fail.

@jkroepke jkroepke changed the title 0.5.0 is finding more files? 0.5.0: bat files and checkbashisms incompatibility Jul 21, 2022
@jkroepke jkroepke changed the title 0.5.0: bat files and checkbashisms incompatibility 0.5.0: bats files and checkbashisms incompatibility Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant