DM-53152: Fixed incorrect handling of responses from REST services

Author: iagaponenko

src/czar/HttpCzarIngestModule.cc

@@ -186,10 +186,21 @@ json HttpCzarIngestModule::_ingestData() {
                     // Process workers' responses.
                     map<string, string> errors;
                     for (auto const& [workerId, req] : workerRequests) {
-                        if (req->responseCode() != qhttp::STATUS_OK) {
-                            errors[workerId] = "http_code: " + to_string(req->responseCode());
+                        string error;
+                        if (req->state() == http::AsyncReq::State::FINISHED) {
+                            if (req->responseCode() != qhttp::STATUS_OK) {
+                                errors[workerId] =
+                                        "request state: " + http::AsyncReq::state2str(req->state()) +
+                                        ", error: " + req->errorMessage() +
+                                        ", http_code: " + to_string(req->responseCode());
+                                continue;
+                            }
+                        } else {
+                            errors[workerId] = "request state: " + http::AsyncReq::state2str(req->state()) +
+                                               ", error: " + req->errorMessage();
                             continue;
                         }
+
                         json resp;
                         try {
                             resp = json::parse(req->responseBody());

src/czar/HttpCzarIngestModuleBase.cc

@@ -310,9 +310,21 @@ json HttpCzarIngestModuleBase::_request(http::Method method, string const& url,
     auto const request = _asyncRequest(method, url, data);
     request->start();
     request->wait();
-    if (request->responseCode() != qhttp::STATUS_OK) {
-        throw http::Error(__func__, "http_code: " + to_string(request->responseCode()), errorExt);
+    if (request->state() == http::AsyncReq::State::FINISHED) {
+        if (request->responseCode() != qhttp::STATUS_OK) {
+            throw http::Error(__func__,
+                              "request state: " + http::AsyncReq::state2str(request->state()) +
+                                      ", error: " + request->errorMessage() +
+                                      ", http_code: " + to_string(request->responseCode()),
+                              errorExt);
+        }
+    } else {
+        throw http::Error(__func__,
+                          "request state: " + http::AsyncReq::state2str(request->state()) +
+                                  ", error: " + request->errorMessage(),
+                          errorExt);
     }
+
     json response;
     try {
         response = json::parse(request->responseBody());