NO SUBCHUNK MATERIALIZATION: Temporary commit

The work in progress. Still working on qana::RelationGraph
to move away from query rewriting for materialized sub-chunks
and inject constaints for sub-chunks on the chunk and chunk overlap
tables. The uit test still fails in:

  qproc/testQueryAnaGeneral:246
  qproc/testQueryAnaGeneral:1296

More details can be found in the file a.txt that is located
at the home folder of the package.

Author: iagaponenko

src/qana/RelationGraph.cc

@@ -33,6 +33,7 @@
 #include <limits>
 #include <memory>
 #include <stdexcept>
+#include <unordered_set>
 
 // LSST headers
 #include "lsst/log/Log.h"
@@ -79,10 +80,12 @@ using query::QueryTemplate;
 using query::SelectStmt;
 using query::TableRef;
 using query::TableRefList;
+using query::ValueExpr;
 using query::ValueExprPtr;
 using query::ValueExprPtrVector;
 using query::ValueFactor;
 using query::ValueFactorPtr;
+using query::WhereClause;
 
 std::ostream& operator<<(std::ostream& out, Vertex const& vertex) {
     out << "Vertex("
@@ -155,6 +158,13 @@ void Vertex::insert(Edge const& e) {
     }
 }
 
+std::shared_ptr<CompPredicate> Vertex::makeSubChunkCompPredicate() const {
+    auto const table = tr.hasAlias() ? tr.getAlias() : info->table;
+    return std::make_shared<CompPredicate>(ValueExpr::newColumnExpr("", table, "", SUB_CHUNK_COLUMN),
+                                           CompPredicate::EQUALS_OP,
+                                           ValueExpr::newSimple(ValueFactor::newConstFactor(SUBCHUNK_TAG)));
+}
+
 // ----------------------------------------------------------------
 // RelationGraph implementation
 
@@ -1029,12 +1039,14 @@ void RelationGraph::rewrite(SelectStmtPtrVector& outputs, QueryMapping& mapping)
     // Find directors for which overlap is required. At the same time, rewrite
     // all table references as their corresponding chunk templates.
     std::vector<Vertex*> overlapRefs;
+    LOGS(_log, LOG_LVL_INFO, "1:   rewrite _vertices.size()=" << _vertices.size());
     for (ListIter i = _vertices.begin(), e = _vertices.end(); i != e; ++i) {
         i->rewriteAsChunkTemplate();
         if (i->info->kind == TableInfo::DIRECTOR && i->overlap > 0.0) {
             overlapRefs.push_back(&(*i));
         }
     }
+    LOGS(_log, LOG_LVL_INFO, "2:   rewrite overlapRefs.size()=" << overlapRefs.size());
     if (overlapRefs.empty()) {
         // There is no need for sub-chunking, so leave it off for now.
         //
@@ -1058,31 +1070,80 @@ void RelationGraph::rewrite(SelectStmtPtrVector& outputs, QueryMapping& mapping)
                 "references that require overlap");
     }
 
+    // Add sub-chunk constraint for all director & match tables
+    // Collect full table names (or aliases) in a set to avoid duplicates in setting sub-chunk constraints
+    std::unordered_set<std::string> tableNames;
+    for (ListIter i = _vertices.begin(), e = _vertices.end(); i != e; ++i) {
+        std::string kindName;
+        switch (i->info->kind) {
+            case TableInfo::DIRECTOR:
+                kindName = "DIRECTOR";
+                break;
+            case TableInfo::CHILD:
+                kindName = "CHILD";
+                break;
+            case TableInfo::MATCH:
+                kindName = "MATCH";
+                break;
+            default:
+                kindName = "UNKNOWN";
+                break;
+        }
+        LOGS(_log, LOG_LVL_INFO,
+             "3:   rewrite i->tr.getAlias()=" << i->tr.getAlias() << " i->info->table=" << i->info->table
+                                              << " overlap=" << i->overlap << " kind=" << kindName);
+        if (i->info->kind == TableInfo::DIRECTOR || i->info->kind == TableInfo::MATCH) {
+            std::string tableName;
+            if (i->tr.hasAlias()) {
+                tableName = i->tr.getAlias();
+            } else {
+                tableName = i->info->database + "." + i->info->table;
+            }
+            if (tableNames.count(tableName) == 0) {
+                tableNames.insert(tableName);
+                auto predicate = i->makeSubChunkCompPredicate();
+                BoolFactor::Ptr bfactor = std::make_shared<BoolFactor>();
+                bfactor->_terms.push_back(predicate);
+                _query->getWhereClause(true).prependAndTerm(bfactor);
+            }
+        }
+    }
+
     // Rewrite director table references not requiring overlap as their
     // corresponding sub-chunk templates, and record the names of all
     // sub-chunked tables.
     for (ListIter i = _vertices.begin(), e = _vertices.end(); i != e; ++i) {
         if (i->info->kind == TableInfo::DIRECTOR) {
             if (i->overlap == 0.0) {
-                i->rewriteAsSubChunkTemplate();
+                i->rewriteAsChunkTemplate();
             }
             DbTable dbTable(i->info->database, i->info->table);
-            LOGS(_log, LOG_LVL_TRACE, "rewrite db=" << dbTable.db << " table=" << dbTable.table);
+            LOGS(_log, LOG_LVL_INFO,
+                 "4:   rewrite db=" << i->info->database << " table=" << i->info->table
+                                    << " overlap=" << i->overlap);
             mapping.insertSubChunkTable(dbTable);
         }
     }
     unsigned n = static_cast<unsigned>(overlapRefs.size());
     unsigned numPermutations = 1 << n;
-    // Each director requiring overlap must be rewritten as both a sub-chunk
-    // template and an overlap sub-chunk template. There are 2ⁿ different
+    // Each director requiring overlap must be rewritten as both a chunk
+    // template and chunk overlap template. There are 2ⁿ different
     // template permutations for n directors requiring overlap; generate them
     // all.
     for (unsigned p = 0; p < numPermutations; ++p) {
         for (unsigned i = 0; i < n; ++i) {
             if ((p & (1 << i)) != 0) {
                 overlapRefs[i]->rewriteAsOverlapTemplate();
+                LOGS(_log, LOG_LVL_INFO,
+                     "5.o: rewrite db=" << overlapRefs[i]->info->database
+                                        << " table=" << overlapRefs[i]->info->table
+                                        << " overlap=" << overlapRefs[i]->overlap);
             } else {
-                overlapRefs[i]->rewriteAsSubChunkTemplate();
+                overlapRefs[i]->rewriteAsChunkTemplate();
+                LOGS(_log, LOG_LVL_INFO,
+                     "5.c: rewrite db=" << overlapRefs[i]->info->database
+                                        << " table=" << overlapRefs[i]->info->table
+                                        << " overlap=" << overlapRefs[i]->overlap);
             }
         }
         // Given the use of shared_ptr by the IR classes, we could shallow

src/qana/RelationGraph.h

@@ -494,6 +494,7 @@
 namespace lsst::qserv {
 namespace query {
 class ColumnRef;
+class CompPredicate;
 class QueryContext;
 class SelectStmt;
 }  // namespace query
@@ -577,19 +578,16 @@ struct Vertex {
         tr.setTable(info->getChunkTemplate());
     }
 
-    /// `rewriteAsSubChunkTemplate` rewrites `tr` to contain a sub-chunk
-    /// specific name pattern.
-    void rewriteAsSubChunkTemplate() {
-        tr.setDb(info->getSubChunkDb());
-        tr.setTable(info->getSubChunkTemplate());
-    }
-
     /// `rewriteAsOverlapTemplate` rewrites `tr` to contain an overlap
     /// sub-chunk specific name pattern.
     void rewriteAsOverlapTemplate() {
-        tr.setDb(info->getSubChunkDb());
+        tr.setDb(info->database);
         tr.setTable(info->getOverlapTemplate());
     }
+
+    /// `makeSubChunkCompPredicate` creates a shared pointer to a new
+    /// comparison predicate for the sub-chunk column.
+    std::shared_ptr<query::CompPredicate> makeSubChunkCompPredicate() const;
 };
 
 std::ostream& operator<<(std::ostream& out, Vertex const& vertex);

src/qana/TableInfo.h

@@ -69,7 +69,7 @@
 #include <vector>
 
 // Qserv headers
-#include "global/constants.h"  // for SUBCHUNKDB_PREFIX
+#include "global/constants.h"
 
 // Forward declarations
 namespace lsst::qserv::query {
@@ -134,12 +134,8 @@ struct TableInfo {
         return false;
     }
 
-    std::string const getSubChunkDb() const { return SUBCHUNKDB_PREFIX + database + "_" + CHUNK_TAG; }
     std::string const getChunkTemplate() const { return table + "_" + CHUNK_TAG; }
-    std::string const getSubChunkTemplate() const { return table + "_" + CHUNK_TAG + "_" + SUBCHUNK_TAG; }
-    std::string const getOverlapTemplate() const {
-        return table + "FullOverlap_" + CHUNK_TAG + "_" + SUBCHUNK_TAG;
-    }
+    std::string const getOverlapTemplate() const { return table + "FullOverlap_" + CHUNK_TAG; }
 
     virtual void dump(std::ostream& os) const;
 };

src/qproc/testQueryAnaGeneral.cc

@@ -199,16 +199,20 @@ BOOST_AUTO_TEST_CASE(RestrictorNeighborCount) {
             "where qserv_areaspec_box(6,6,7,7) AND rFlux_PS<0.005 AND "
             "scisql_angSep(o1.ra_Test,o1.decl_Test,o2.ra_Test,o2.decl_Test) < 0.001;";
     std::string expected_100_subchunk_core =
-            "SELECT count(*) AS `QS1_COUNT` FROM `Subchunks_LSST_100`.`Object_100_%S\007S%` AS "
-            "`o1`,`Subchunks_LSST_100`.`Object_100_%S\007S%` AS `o2` "
-            "WHERE scisql_s2PtInBox(`o1`.`ra_Test`,`o1`.`decl_Test`,6,6,7,7)=1 AND "
+            "SELECT count(*) AS `QS1_COUNT` FROM `LSST`.`Object_100` AS "
+            "`o1`,`LSST`.`Object_100` AS `o2` "
+            "WHERE `o2`.`subChunkId`=%S\007S% "
+            "AND `o1`.`subChunkId`=%S\007S% "
+            "AND scisql_s2PtInBox(`o1`.`ra_Test`,`o1`.`decl_Test`,6,6,7,7)=1 AND "
             "scisql_s2PtInBox(`o2`.`ra_Test`,`o2`.`decl_Test`,6,6,7,7)=1 AND "
             "`o1`.`rFlux_PS`<0.005 AND "
             "scisql_angSep(`o1`.`ra_Test`,`o1`.`decl_Test`,`o2`.`ra_Test`,`o2`.`decl_Test`)<0.001";
     std::string expected_100_subchunk_overlap =
-            "SELECT count(*) AS `QS1_COUNT` FROM `Subchunks_LSST_100`.`Object_100_%S\007S%` AS "
-            "`o1`,`Subchunks_LSST_100`.`ObjectFullOverlap_100_%S\007S%` AS `o2` "
-            "WHERE scisql_s2PtInBox(`o1`.`ra_Test`,`o1`.`decl_Test`,6,6,7,7)=1 "
+            "SELECT count(*) AS `QS1_COUNT` FROM `LSST`.`Object_100` AS "
+            "`o1`,`LSST`.`ObjectFullOverlap_100` AS `o2` "
+            "WHERE `o2`.`subChunkId`=%S\007S% "
+            "AND `o1`.`subChunkId`=%S\007S% "
+            "AND scisql_s2PtInBox(`o1`.`ra_Test`,`o1`.`decl_Test`,6,6,7,7)=1 "
             "AND scisql_s2PtInBox(`o2`.`ra_Test`,`o2`.`decl_Test`,6,6,7,7)=1 "
             "AND `o1`.`rFlux_PS`<0.005 AND "
             "scisql_angSep(`o1`.`ra_Test`,`o1`.`decl_Test`,`o2`.`ra_Test`,`o2`.`decl_Test`)<0.001";
@@ -253,9 +257,11 @@ BOOST_AUTO_TEST_CASE(Triple) {
             "0.024 > scisql_angSep(o1.ra_Test,o1.decl_Test,o2.ra_Test,o2.decl_Test) and "
             "Source.objectIdSourceTest=o2.objectIdObjTest;";
     std::string expected =
-            "SELECT * FROM `Subchunks_LSST_100`.`Object_100_%S\007S%` AS "
-            "`o1`,`Subchunks_LSST_100`.`Object_100_%S\007S%` AS `o2`,`LSST`.`Source_100` AS `LSST.Source` "
-            "WHERE `o1`.`id`!=`o2`.`id` AND "
+            "SELECT * FROM `LSST`.`Object_100` AS "
+            "`o1`,`LSST`.`Object_100` AS `o2`,`LSST`.`Source_100` AS `LSST.Source` "
+            "WHERE `o2`.`subChunkId`=%S\007S% "
+            "AND `o1`.`subChunkId`=%S\007S% "
+            "AND `o1`.`id`!=`o2`.`id` AND "
             "0.024>scisql_angSep(`o1`.`ra_Test`,`o1`.`decl_Test`,`o2`.`ra_Test`,`o2`.`decl_Test`) AND "
             "`LSST.Source`.`objectIdSourceTest`=`o2`.`objectIdObjTest`";
 
@@ -509,9 +515,11 @@ BOOST_AUTO_TEST_CASE(ObjectSelfJoinDistance) {
             "scisql_angSep(o1.ra_Test,o1.decl_Test,o2.ra_Test,o2.decl_Test) < 0.02";
     std::string expected =
             "SELECT count(*) AS `QS1_COUNT` "
-            "FROM `Subchunks_LSST_100`.`Object_100_%S\007S%` AS `o1`,"
-            "`Subchunks_LSST_100`.`Object_100_%S\007S%` AS `o2` "
-            "WHERE scisql_s2PtInBox(`o1`.`ra_Test`,`o1`.`decl_Test`,5.5,5.5,6.1,6.1)=1 "
+            "FROM `LSST`.`Object_100` AS `o1`,"
+            "`LSST`.`Object_100` AS `o2` "
+            "WHERE `o2`.`subChunkId`=%S\007S% "
+            "AND `o1`.`subChunkId`=%S\007S% "
+            "AND scisql_s2PtInBox(`o1`.`ra_Test`,`o1`.`decl_Test`,5.5,5.5,6.1,6.1)=1 "
             "AND scisql_s2PtInBox(`o2`.`ra_Test`,`o2`.`decl_Test`,5.5,5.5,6.1,6.1)=1 "
             "AND scisql_angSep(`o1`.`ra_Test`,`o1`.`decl_Test`,`o2`.`ra_Test`,`o2`.`decl_Test`)<0.02";
     qsTest.sqlConfig =
@@ -951,9 +959,11 @@ BOOST_AUTO_TEST_CASE(FuncExprPred) {
            "(scisql_fluxToAbMag(o2.gFlux_PS)-scisql_fluxToAbMag(o2.rFlux_PS)) ) < 1;";
     expected =
             "SELECT `o1`.`objectId` AS `o1.objectId`,`o2`.`objectId` AS `objectId2` "
-            "FROM `Subchunks_LSST_100`.`Object_100_%S\007S%` AS "
-            "`o1`,`Subchunks_LSST_100`.`Object_100_%S\007S%` AS `o2` "
-            "WHERE scisql_angSep(`o1`.`ra_Test`,`o1`.`decl_Test`,`o2`.`ra_Test`,`o2`.`decl_Test`)<0.00001 "
+            "FROM `LSST`.`Object_100` AS "
+            "`o1`,`LSST`.`Object_100` AS `o2` "
+            "WHERE `o2`.`subChunkId`=%S\007S% "
+            "AND `o1`.`subChunkId`=%S\007S% "
+            "AND scisql_angSep(`o1`.`ra_Test`,`o1`.`decl_Test`,`o2`.`ra_Test`,`o2`.`decl_Test`)<0.00001 "
             "AND `o1`.`objectId`<>`o2`.`objectId` AND "
             "ABS((scisql_fluxToAbMag(`o1`.`gFlux_PS`)-scisql_fluxToAbMag(`o1`.`rFlux_PS`))-(scisql_"
             "fluxToAbMag(`o2`.`gFlux_PS`)-scisql_fluxToAbMag(`o2`.`rFlux_PS`)))<1";
@@ -1294,18 +1304,24 @@ BOOST_AUTO_TEST_CASE(Case01_1081) {
             "WHERE  closestToObj = 1 OR closestToObj is NULL;";
     std::string expected_100_subchunk_core =
             "SELECT count(*) AS `QS1_COUNT` "
-            "FROM `Subchunks_LSST_100`.`Object_100_%S\007S%` AS `o` "
+            "FROM `LSST`.`Object_100` AS `o` "
             "INNER JOIN `LSST`.`RefObjMatch_100` AS `o2t` ON `o`.`objectIdObjTest`=`o2t`.`objectId` "
-            "INNER JOIN `Subchunks_LSST_100`.`SimRefObject_100_%S\007S%` AS `t` ON "
+            "INNER JOIN `LSST`.`SimRefObject_100` AS `t` ON "
             "`o2t`.`refObjectId`=`t`.`refObjectId` "
-            "WHERE `o`.`closestToObj`=1 OR `o`.`closestToObj` IS NULL";
+            "WHERE `t`.`subChunkId`=%S\007S% "
+            "AND `o2t`.`subChunkId`=%S\007S% "
+            "AND `o`.`subChunkId`=%S\007S% "
+            "AND (`o`.`closestToObj`=1 OR `o`.`closestToObj` IS NULL)";
     std::string expected_100_subchunk_overlap =
             "SELECT count(*) AS `QS1_COUNT` "
-            "FROM `Subchunks_LSST_100`.`Object_100_%S\007S%` AS `o` "
+            "FROM `LSST`.`Object_100` AS `o` "
             "INNER JOIN `LSST`.`RefObjMatch_100` AS `o2t` ON `o`.`objectIdObjTest`=`o2t`.`objectId` "
-            "INNER JOIN `Subchunks_LSST_100`.`SimRefObjectFullOverlap_100_%S\007S%` AS `t` ON "
+            "INNER JOIN `LSST`.`SimRefObjectFullOverlap_100` AS `t` ON "
             "`o2t`.`refObjectId`=`t`.`refObjectId` "
-            "WHERE `o`.`closestToObj`=1 OR `o`.`closestToObj` IS NULL";
+            "WHERE `t`.`subChunkId`=%S\007S% "
+            "AND `o2t`.`subChunkId`=%S\007S% "
+            "AND `o`.`subChunkId`=%S\007S% "
+            "AND (`o`.`closestToObj`=1 OR `o`.`closestToObj` IS NULL)";
     qsTest.sqlConfig =
             SqlConfig(SqlConfig::MockDbTableColumns({{"LSST",
                                                       {{"Object", {"objectIdObjTest", "closestToObj"}},

src/query/SelectStmt.cc

@@ -169,6 +169,11 @@ void SelectStmt::setFromListAsTable(std::string const& t) {
     _fromList = std::make_shared<FromList>(tr);
 }
 
+WhereClause& SelectStmt::getWhereClause(bool createIfMissing) {
+    if (createIfMissing && !_whereClause) _whereClause = std::make_shared<WhereClause>();
+    return *_whereClause;
+}
+
 bool SelectStmt::operator==(const SelectStmt& rhs) const {
     return (util::ptrCompare<FromList>(_fromList, rhs._fromList) &&
             util::ptrCompare<SelectList>(_selectList, rhs._selectList) &&

src/query/SelectStmt.h

@@ -104,7 +104,7 @@ class SelectStmt {
 
     bool hasWhereClause() const { return static_cast<bool>(_whereClause); }
     WhereClause const& getWhereClause() const { return *_whereClause; }
-    WhereClause& getWhereClause() { return *_whereClause; }
+    WhereClause& getWhereClause(bool createIfMissing = false);
     void setWhereClause(std::shared_ptr<WhereClause> w) { _whereClause = w; }
 
     /**