Skip to content

Commit 11a5893

Browse files
committed
NO SUBCHUNK MATERIALIZATION: cleanup at workers (1)
1 parent f7acd29 commit 11a5893

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

src/wbase/Task.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ Task::Task(TaskMsgPtr const& t, int fragmentNumber, shared_ptr<UserQueryInfo> co
164164
_scanInfo.sortTablesSlowestFirst();
165165
_scanInteractive = t->scaninteractive();
166166
_maxTableSize = t->maxtablesize_mb() * ::MB_SIZE_BYTES;
167-
167+
#if 0
168168
// Create sets and vectors for 'aquiring' subchunk temporary tables.
169169
proto::TaskMsg_Fragment const& fragment(t->fragment(_queryFragmentNum));
170170
DbTableSet dbTbls_;
@@ -203,6 +203,7 @@ Task::Task(TaskMsgPtr const& t, int fragmentNumber, shared_ptr<UserQueryInfo> co
203203
<< " subChunks=" << util::printable(subchunksVect_));
204204
}
205205
_dbTblsAndSubchunks = make_unique<DbTblsAndSubchunks>(dbTbls_, subchunksVect_);
206+
#endif
206207
if (_sendChannel == nullptr) {
207208
throw util::Bug(ERR_LOC, "Task::Task _sendChannel==null " + getIdStr());
208209
}

src/wbase/Task.h

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ class Task : public util::CommandForThreadPool {
126126
static std::string const defaultUser;
127127
using Ptr = std::shared_ptr<Task>;
128128
using TaskMsgPtr = std::shared_ptr<proto::TaskMsg>;
129-
129+
#if 0
130130
/// Class to store constant sets and vectors.
131131
class DbTblsAndSubchunks {
132132
public:
@@ -144,7 +144,7 @@ class Task : public util::CommandForThreadPool {
144144
/// Vector of subchunkIds. Set in constructor and should never change.
145145
const IntVector subchunksVect;
146146
};
147-
147+
#endif
148148
struct ChunkEqual {
149149
bool operator()(Ptr const& x, Ptr const& y);
150150
};
@@ -272,10 +272,7 @@ class Task : public util::CommandForThreadPool {
272272
int getSubchunkId() const { return _subchunkId; }
273273

274274
/// Returns a reference to dbTbls.
275-
const DbTableSet& getDbTbls() const { return _dbTblsAndSubchunks->dbTbls; }
276-
277-
/// Return a reference to the list of subchunk ids.
278-
const IntVector& getSubchunksVect() const { return _dbTblsAndSubchunks->subchunksVect; }
275+
// const DbTableSet& getDbTbls() const { return _dbTblsAndSubchunks->dbTbls; }
279276

280277
/// Return an identifier of the corresponding MySQL query (if any was set).
281278
unsigned long getMySqlThreadId() const { return _mysqlThreadId.load(); }
@@ -317,7 +314,7 @@ class Task : public util::CommandForThreadPool {
317314
int const _czarId; ///< czar Id from the task message.
318315

319316
/// Set of tables and vector of subchunk ids used by ChunkResourceRequest. Do not change/reset.
320-
std::unique_ptr<DbTblsAndSubchunks> _dbTblsAndSubchunks;
317+
// std::unique_ptr<DbTblsAndSubchunks> _dbTblsAndSubchunks;
321318

322319
/// The path to the result file.
323320
std::string _resultFileAbsPath;

0 commit comments

Comments
 (0)