Skip to content
This repository has been archived by the owner on Oct 19, 2021. It is now read-only.

Missing Indoor Temperature Styling #1

Open
OlsBean opened this issue Jul 29, 2016 · 14 comments
Open

Missing Indoor Temperature Styling #1

OlsBean opened this issue Jul 29, 2016 · 14 comments

Comments

@OlsBean
Copy link

OlsBean commented Jul 29, 2016

Not sure if this is the correct place to put this as I have not used Github before.

I've been playing with this template, trying to use it to display data locally from the AERCUS Weathersleuth. I've found there is some missing CSS for the Indoor Temperature, causing it to display out of place and without styling. Adding this back into the main Stylesheet corrected it.

`.indoortemptexthot {
color: #f26c4f;
position: absolute;
padding-top: 0;
font: 28px weathertext, Arial;
position: absolute;
top:15px;
margin-left:190px;

}

.indoortemptextcool {
color: #f26c4f;
position: absolute;
padding-top: 0;
font: 28px weathertext, Arial;
position: absolute;
top:15px;
margin-left:190px;

}

.indoortemptextcooler {
color: #66a1ba;
position: absolute;
padding-top: 0;
font: 28px weathertext, Arial;
position: absolute;
top:15px;
margin-left:190px;

}`

@lrosenman
Copy link
Owner

This IS the correct place. Which version (light/dark, ws1001, ws1001f, ws1001uk)?

I'll take a look today or tonight.

@OlsBean
Copy link
Author

OlsBean commented Jul 29, 2016

I am using ws1001uk Dark at the moment.
w_css

@OlsBean OlsBean closed this as completed Jul 29, 2016
@lrosenman
Copy link
Owner

Why did you close it? I haven't merged your fix in....

@lrosenman lrosenman reopened this Jul 29, 2016
@OlsBean
Copy link
Author

OlsBean commented Jul 29, 2016

Sorry Must have clicked the wrong button, not used it before.

@weather34
Copy link

this issue was addressed some time ago not sure which version he is showing and the forecast is out of date or not running for a long time .
438d

@lrosenman
Copy link
Owner

@OlsBean can you look at my site (http://weather.lerctr.org) and do you see the same thing?

Thanks.

@OlsBean
Copy link
Author

OlsBean commented Jul 29, 2016

@lrosenman No your site is fine.

@weather34 It's not wired up as I am still in the process of working out the best way to get the Data from my PWS, it's literally the fresh Template files from both;

WS1001-Template-rev-4.36-PostgresDB\WS1001-Template-rev-4.36-PostgresDB\dark\ws1001ukd

WS1001-Template-rev-4.36\WS1001-Template-rev-4.36\dark\ws1001ukd

Dropped into Local IIS, I only downloaded your template yesterday or the day before. The error is not in the Light version from what I can see.

Thank you for all your hard work and for sharing this template.

Best Wishes

@lrosenman
Copy link
Owner

Ok, I'll compare/contrast light/dark, and fix it.
I have some other updates from @weather34 to apply as well

@OlsBean can you send me a diff with the patch?

@lrosenman
Copy link
Owner

or attach your (fixed) copy of the file. Thanks!

@OlsBean
Copy link
Author

OlsBean commented Jul 29, 2016

I can share my fix but it's probably a dirty fix! I'm no developer nor claim to be, not done anything since SoopPortal many moons ago.

Looking over the files quickly it seems that the styles in indoor.php in the Light version are different to those in the Dark version (UK). I've added the missing "Wrong" styles into the CSS from a much older version of the Template which I gleaned off the WD site but I guess the proper way to go would be to update the indoor.php to reflect the other versions, that way there should not be an need to add them.
main.min.zip

@lrosenman
Copy link
Owner

Ok -- I'll verify when I do the merge this weekend.

thanks.

@OlsBean
Copy link
Author

OlsBean commented Jul 29, 2016

JFYI - I just replaced the indoor.php in the UK Dark with the one from the Light and that fixed it, without any need to play around with CSS. So that was it, I guess, the clean fix.

@lrosenman
Copy link
Owner

Cool -- I'll make that change later and move the tag. Thank You for the help.

@OlsBean
Copy link
Author

OlsBean commented Jul 29, 2016

Thank you for all your help!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants