Skip to content

Commit 6f186e8

Browse files
committed
[ot] ci: .github,.gitlab-ci.d: replace ot-tidy.sh with ot_tidy.py
Replaces all usages, updates docs, and removes the older script. Signed-off-by: Alice Ziuziakowska <[email protected]>
1 parent 5c79f5d commit 6f186e8

File tree

4 files changed

+5
-77
lines changed

4 files changed

+5
-77
lines changed

.github/workflows/build_test.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
# QEMU OpenTitan CI
44
#
55
# Copyright (c) 2023-2025 Rivos, Inc.
6+
# Copyright (c) 2025 lowRISC contributors.
7+
#
68
# SPDX-License-Identifier: Apache License 2.0
79
#------------------------------------------------------------------------------
810

@@ -121,7 +123,7 @@ jobs:
121123
- name: Clang tidy
122124
# Expect many warnings/errors (accounted but not reported) from included QEMU files
123125
run: |
124-
scripts/opentitan/ot-tidy.sh --ci -p build-clang
126+
scripts/opentitan/ot_tidy.py --build-dir build-clang --ci-files -j
125127
126128
lint-commits:
127129
runs-on: ubuntu-latest

.gitlab-ci.d/opentitan/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,4 +73,4 @@ tidy:
7373
script:
7474
- QEMU_DIR="$(pwd -P)"; cat build/compile_commands.json.tpl |
7575
sed -E 's,@QEMU_DIR@,'"$QEMU_DIR"',g' > build/compile_commands.json
76-
- scripts/opentitan/ot-tidy.sh --ci -p build
76+
- scripts/opentitan/ot_tidy.py --build-dir build --ci-files -j

docs/opentitan/tools.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ of options and the available features.
5050
* [`keymgre-dpe.py`](keymgre-dpe.md) is a simple Python tool to generate KeyManager DPE output keys
5151
using the same parameters as the KeyManager DPE. It is dedicated to unit test purposes.
5252
* `ot-format.sh` is a simple shell wrapper to run clang-format (code formatter) on OpenTitan files
53-
* `ot-tidy.sh` is a simple shell wrapper to run clang-tidy (C linter) on OpenTitan files
53+
* `ot_tidy.py` is a python wrapper script to run clang-tidy (C linter) on OpenTitan files, optionally in parallel and locally or in CI.
5454
* `present.py` implements the Present 128-bit scrambler/descrambler used in OTP image files for
5555
HW digest verification.
5656
* [spidevice.py](spidevice.md) is a tiny script to upload a binary using the SPI device.

scripts/opentitan/ot-tidy.sh

Lines changed: 0 additions & 74 deletions
This file was deleted.

0 commit comments

Comments
 (0)