Bug Fixes

Author: LT-Rascek

WtWSMS/common/on_action/BP_roman_administrative/BP_roman_admin_title_on_actions.txt

@@ -56,6 +56,7 @@ BP_keep_roman_federate_government = {
 	trigger = {
 		BP_has_dlc_necessary_for_roman_governments_trigger = yes
 		is_independent_ruler = no
+		is_landed = no
 	}
 	effect = {
 		if = {

WtWSMS/common/scripted_effects/BP_roman_administrative_effects.txt

@@ -457,6 +457,16 @@ change_government_roman_federate_effect = {
 			destroy_maa_regiment = yes
 		}
 	}
+	if = {
+		limit = { any_held_title = { is_noble_family_title = yes } }
+		custom_tooltip = {
+			text = destroy_noble_family_titles
+			every_held_title = {
+				limit = { is_noble_family_title = yes }
+				prev = { destroy_title = prev }
+			}
+		}
+	}
 }
 change_government_subroman_administrative_effect = {
 	change_government = subroman_administrative_government

WtWSMS/common/succession_appointment/BP_roman_federate.txt

@@ -1,5 +1,8 @@
 roman_federate_succession = {
-	default_candidates = { holder_close_family holder_close_extended_family holder_house_member holder_councilor holder_court_position landed_vassal direct_subject }
+	default_candidates = { holder_close_family holder_close_extended_family holder_house_member holder_councilor holder_court_position direct_subject }
+
+	allow_same_tier_candidates = no
+	allow_children = yes
 
 	candidate_score = {
 		value = {
@@ -871,6 +874,34 @@
 					desc = same_heritage_group_tt
 				}
 			}
+			else_if = {
+				limit = { culture = { has_cultural_parameter = greco_roman_social_tradition } }
+				subtract = {
+					value = 5000
+					if = {
+						limit = { scope:title.holder = { bp_succession_weight_dynastic_1_trigger = yes } }
+						multiply = succession_weight_dynastic_1_value
+					}
+					else_if = {
+						limit = { scope:title.holder = { bp_succession_weight_dynastic_2_trigger = yes } }
+						multiply = 0.5
+					}
+					else_if = {
+						limit = { scope:title.holder = { bp_succession_weight_dynastic_3_trigger = yes } }
+						multiply = succession_weight_dynastic_3_value
+					}
+					else_if = {
+						limit = { scope:title.holder = { bp_succession_weight_dynastic_4_trigger = yes } }
+						multiply = succession_weight_dynastic_4_value
+					}
+					else_if = {
+						limit = { scope:title.holder = { bp_succession_weight_purely_dynastic_trigger = yes } }
+						multiply = succession_is_purely_dynastic_value
+					}
+					multiply = 2.0 #Romanitas is still very odd for Federates
+					desc = roman_culture_tt
+				}
+			}
 			else = {
 				subtract = {
 					value = 50
@@ -898,6 +929,20 @@
 				}
 			}
 
+			#Already
+			if = {
+				limit = {
+					OR = {
+						is_landed = yes
+						is_landless_ruler = yes
+					}
+				}
+				subtract = {
+					value = 5000
+					desc = already_landed_tt
+				}
+			}
+
 			#ADJUST BASED ON GENDER LAW - MUST GO AT THE END
 			if = {
 				limit = {

WtWSMS/localization/english/BP_effects_l_english.yml

@@ -21,4 +21,5 @@
  ALL_VASSALS_ROMAN_APPROVE: "Every Roman or Greek [vassal|E] and below or [courtier|E] gains $VALUE|+0$ [opinion|E] of [CHARACTER.GetShortUIName] for 30 years #weak ($reduced_roman_priveleges_roman$)#!"
  ALL_VASSALS_ROMAN_DISAPPROVE: "Every Roman or Greek [vassal|E] and below or [courtier|E] looses #N $VALUE|0$#! [opinion|E] of [CHARACTER.GetShortUIName] for 30 years #weak ($improved_roman_priveleges_roman$)#!"
  #Roman Federate Conversion
- personal_maa_transfer_to_title: "Personal men at arms become title men at arms"
+ personal_maa_transfer_to_title: "Personal men at arms become title men at arms"
+ destroy_noble_family_titles: "Noble Family titles are destroyed"

WtWSMS/localization/english/BP_succ_appointment_l_english.yml

@@ -3,12 +3,14 @@
  same_heritage_tt: "Same [heritage|E]"
  same_heritage_continua_tt: "Same [kulturbund|E]"
  same_heritage_group_tt: "Same [heritage_group|E]"
+ roman_culture_tt: "Romance [culture|E]"
  alien_culture_tt: "Alien Culture"
  child_of_holder_desc: "Child of the current holder"
  strong_implicit_title_claim_desc: "Has a strong implicit claim"
  weak_implicit_title_claim_desc: "Has a weak implicit claim"
  theocratic_lesee: "Theocrat"
  federate_government_tt: "$roman_federate_government$"
+ already_landed_tt: "Already Landed"
 
  roman_politics_dynasty_legacy_impact_tt: "$BP_roman_heritage_legacy_3_name$ Dynasty Perk"
  is_a_senator: "Senator"