Skip to content

Commit

Permalink
Merge pull request #25 from lolmaus/first-release
Browse files Browse the repository at this point in the history
Bunch of updates for the first release
  • Loading branch information
lolmaus authored Jun 24, 2021
2 parents f6767a1 + 801227b commit 67b1460
Show file tree
Hide file tree
Showing 35 changed files with 5,731 additions and 2,296 deletions.
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

# misc
/coverage/
.eslintcache

# ember-try
/.node_modules.ember-try/
Expand Down
10 changes: 7 additions & 3 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const nodeFiles = [
'config/**/*.{js,ts}',
'lib/*/index.{js,ts}',
'server/**/*.{js,ts}',
'tests/dummy/config/**/*.{js,ts}',
];

const browserFiles = [
Expand All @@ -29,6 +30,9 @@ module.exports = {
parserOptions: {
ecmaVersion: 2018,
sourceType: 'module',
ecmaFeatures: {
legacyDecorators: true,
},
project: ['./tsconfig.json', './tsconfig-node.json'],
},
plugins: ['@typescript-eslint', 'ember', 'prettier'],
Expand All @@ -40,8 +44,7 @@ module.exports = {
'plugin:ember/recommended',
'standard',

'prettier/@typescript-eslint',
'prettier/standard',
'prettier',

// This one should come last
'plugin:prettier/recommended',
Expand Down Expand Up @@ -75,6 +78,7 @@ module.exports = {
camelcase: 'off', // Have to keep this off for the TS equivalent to take precedence
'no-console': ['error', { allow: ['debug', 'error', 'info', 'warn'] }],
'no-unused-expressions': 'off',
'no-use-before-define': 'off', // We need circular references
'no-useless-constructor': 'off', // This rule crashes ESLint unless disabled

'node/no-unpublished-require': 'off', // Reenabled for non-Node files only
Expand All @@ -94,8 +98,8 @@ module.exports = {
node: true,
},
plugins: ['node'],
extends: ['plugin:node/recommended'],
rules: {
...require('eslint-plugin-node').configs.recommended.rules, // eslint-disable-line node/no-unpublished-require
// add your custom rules and overrides for node files here
'node/no-unsupported-features/es-syntax': ['error', { version: '>=12.0.0' }],
},
Expand Down
76 changes: 76 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
name: CI

on:
push:
branches:
- gen-4
tags:
- '*'
pull_request:
schedule:
- cron: '0 4 * * 5' # Fridays at 4am

jobs:
test:
name: Tests
runs-on: ubuntu-latest

steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Setup node.js
uses: actions/setup-node@v1
with:
node-version: 12
- name: Install dependencies
uses: bahmutov/npm-install@v1
- name: Lint
run: yarn lint
- name: Test
run: yarn test:ember

test-no-lock:
name: Floating Dependencies
runs-on: ubuntu-latest
needs:
- test
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Setup node.js
uses: actions/setup-node@v1
with:
node-version: 12
- name: Install dependencies
uses: bahmutov/npm-install@v1
with:
useLockFile: false
- name: Test
run: yarn test:ember

test-try:
name: Additional Tests
runs-on: ubuntu-latest
needs:
- test
strategy:
matrix:
scenario:
- ember-lts-3.16
- ember-lts-3.20
- ember-release
- ember-beta
- ember-canary
- ember-default-with-jquery
- ember-classic
steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Setup node.js
uses: actions/setup-node@v1
with:
node-version: 12
- name: Install dependencies
uses: bahmutov/npm-install@v1
- name: Test
run: yarn ember try:one ${{ matrix.scenario }}
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

# misc
/.sass-cache
/.eslintcache
/connect.lock
/coverage/
/libpeerconnection.log
Expand Down
3 changes: 3 additions & 0 deletions .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,13 @@
/.editorconfig
/.ember-cli
/.env*
/.eslintcache
/.eslintignore
/.eslintrc.js
/.git/
/.gitignore
/.prettierignore
/.prettierrc.js
/.template-lintrc.js
/.travis.yml
/.watchmanconfig
Expand Down
21 changes: 21 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# unconventional js
/blueprints/*/files/
/vendor/

# compiled output
/dist/
/tmp/

# dependencies
/bower_components/
/node_modules/

# misc
/coverage/
!.*
.eslintcache

# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/package.json.ember-try
2 changes: 2 additions & 0 deletions .prettierrc.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
'use strict';

module.exports = {
arrowParens: 'always', // It's convenient that you don't have to add them by hand when you need to add more args or a type
singleQuote: true, // Enabled to align with EmberJS Prettier config
Expand Down
5 changes: 5 additions & 0 deletions .release-it.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"github": {
"release": true
}
}
2 changes: 1 addition & 1 deletion .template-lintrc.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';

module.exports = {
extends: 'recommended'
extends: 'octane',
};
9 changes: 4 additions & 5 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ node_js:
# so that your addon works for all apps
- "10"

dist: trusty
dist: xenial

addons:
chrome: stable
Expand Down Expand Up @@ -46,20 +46,19 @@ jobs:

# we recommend new addons test the current and previous LTS
# as well as latest stable release (bonus points to beta/canary)
- env: EMBER_TRY_SCENARIO=ember-lts-3.12
- env: EMBER_TRY_SCENARIO=ember-lts-3.16
- env: EMBER_TRY_SCENARIO=ember-lts-3.20
- env: EMBER_TRY_SCENARIO=ember-release
- env: EMBER_TRY_SCENARIO=ember-beta
- env: EMBER_TRY_SCENARIO=ember-canary
- env: EMBER_TRY_SCENARIO=ember-default-with-jquery
- env: EMBER_TRY_SCENARIO=ember-classic
- env: EMBER_TRY_SCENARIO=embroider-safe
- env: EMBER_TRY_SCENARIO=embroider-optimized

before_install:
- curl -o- -L https://yarnpkg.com/install.sh | bash
- export PATH=$HOME/.yarn/bin:$PATH

install:
- yarn install --non-interactive

script:
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Changelog
5 changes: 2 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@

## Linting

* `yarn lint:hbs`
* `yarn lint:js`
* `yarn lint:js --fix`
* `yarn lint`
* `yarn lint:fix`

## Running tests

Expand Down
Loading

0 comments on commit 67b1460

Please sign in to comment.