chore: add swift lint

Author: lodev09

Diff for: example/.prettierignore

@@ -22,7 +22,7 @@ const config = {
   // So we block them at the root, and alias them to the versions in example's node_modules
   resolver: {
     blacklistRE: exclusionList(
-      modules.map((m) => new RegExp(`^${escape(path.join(root, 'node_modules', m))}\\/.*$`)),
+      modules.map((m) => new RegExp(`^${escape(path.join(root, 'node_modules', m))}\\/.*$`))
     ),
 
     extraNodeModules: modules.reduce((acc, name) => {

Diff for: example/metro.config.js

@@ -8,10 +8,7 @@
     "setup": "npx expo prebuild",
     "clean": "yarn setup --clean",
     "doctor": "npx expo-doctor",
-    "ios": "expo run:ios",
-    "web": "expo start --web",
-    "typecheck": "tsc --noEmit -p . --pretty",
-    "tidy": "prettier --write \"**/*.{js,json,ts,tsx}\""
+    "ios": "expo run:ios"
   },
   "dependencies": {
     "expo": "~50.0.13",
@@ -28,17 +25,7 @@
     "@babel/preset-env": "^7.20.0",
     "@babel/runtime": "^7.20.0",
     "@react-native/metro-config": "^0.73.5",
-    "@react-native/typescript-config": "^0.74.0",
-    "@types/react": "~18.2.45",
-    "babel-plugin-module-resolver": "^5.0.0",
-    "prettier": "^3.2.5",
-    "typescript": "^5.1.3"
-  },
-  "prettier": {
-    "printWidth": 100,
-    "semi": false,
-    "singleQuote": true,
-    "trailingComma": "all"
+    "babel-plugin-module-resolver": "^5.0.0"
   },
   "engines": {
     "node": ">=18"

Diff for: example/package.json

@@ -5,7 +5,7 @@ import type { Position } from './types'
  */
 export const mockPosition = (
   center: Position = [-105.358887, 39.113014],
-  radiusKm = 10,
+  radiusKm = 10
 ): Position => {
   const centerLng = center[0]
   const centerLat = center[1]

Diff for: example/src/utils/mockPosition.ts

@@ -0,0 +1 @@
+5.2

Diff for: ios/.swift-version

@@ -0,0 +1,12 @@
+--allman false
+--indent 2
+--exclude Pods,Generated
+
+--disable andOperator
+--disable redundantReturn
+--disable wrapMultilineStatementBraces
+--disable organizeDeclarations
+
+--enable markTypes
+
+--enable isEmpty

Diff for: ios/.swiftformat

@@ -0,0 +1,52 @@
+disabled_rules:
+  - identifier_name
+  - trailing_comma
+  - todo
+  - type_body_length
+  - cyclomatic_complexity
+  - function_body_length
+  - for_where
+opt_in_rules:
+  - contains_over_filter_count
+  - contains_over_filter_is_empty
+  - contains_over_first_not_nil
+  - contains_over_range_nil_comparison
+  - empty_collection_literal
+  - empty_count
+  - empty_string
+  - first_where
+  - flatmap_over_map_reduce
+  - last_where
+  - reduce_boolean
+  - reduce_into
+  - yoda_condition
+  - vertical_whitespace_opening_braces
+  - vertical_whitespace_closing_braces
+  - vertical_parameter_alignment_on_call
+  - untyped_error_in_catch
+  - unowned_variable_capture
+  - unavailable_function
+  - switch_case_on_newline
+  - static_operator
+  - strict_fileprivate
+  - sorted_imports
+  - sorted_first_last
+  - required_enum_case
+  - redundant_type_annotation
+  - redundant_nil_coalescing
+  - attributes
+  - convenience_type
+analyzer_rules:
+  - explicit_self
+  - unused_declaration
+  - unused_import
+
+excluded: # paths to ignore during linting. Takes precedence over `included`.
+  - Pods
+
+# Adjust rule numbers
+line_length: 160
+file_length: 500
+
+# reporter type (xcode, json, csv, checkstyle, codeclimate, junit, html, emoji, sonarqube, markdown, github-actions-logging)
+reporter: "xcode"

Diff for: ios/.swiftlint.yml

@@ -11,19 +11,18 @@ import PhotosUI
 
 @objc(Exify)
 class Exify: NSObject {
-  
-  func readExif(uri: String, resolve: @escaping RCTPromiseResolveBlock) -> Void {
+  func readExif(uri: String, resolve: @escaping RCTPromiseResolveBlock) {
     guard let url = URL(string: uri) else {
       resolve(nil)
       return
     }
-    
+
     readExifTags(from: url) { tags in
       resolve(tags)
     }
   }
 
-  func readExif(assetId: String, resolve: @escaping RCTPromiseResolveBlock) -> Void {
+  func readExif(assetId: String, resolve: @escaping RCTPromiseResolveBlock) {
     guard let asset = getAssetBy(id: assetId) else {
       resolve(nil)
       return
@@ -32,62 +31,61 @@ class Exify: NSObject {
     let imageOptions = PHContentEditingInputRequestOptions()
     imageOptions.isNetworkAccessAllowed = true
 
-    asset.requestContentEditingInput(with: imageOptions) { contentInput, info in
+    asset.requestContentEditingInput(with: imageOptions) { contentInput, _ in
       guard let url = contentInput?.fullSizeImageURL else {
         resolve(nil)
         return
       }
-      
+
       readExifTags(from: url) { tags in
         resolve(tags)
       }
     }
   }
-  
-  func writeExif(assetId: String, tags: [String: Any], resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) -> Void {
+
+  func writeExif(assetId: String, tags: [String: Any], resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) {
     guard let asset = getAssetBy(id: assetId) else {
       reject("Error", "Cannot retrieve asset.", nil)
       return
     }
-    
+
     let imageOptions = PHContentEditingInputRequestOptions()
     imageOptions.isNetworkAccessAllowed = true
-    
+
     asset.requestContentEditingInput(with: imageOptions) { contentInput, _ in
       guard let contentInput, let url = contentInput.fullSizeImageURL else {
         reject("Error", "Unable to read metadata from asset", nil)
         return
       }
-      
+
       updateMetadata(url: url, with: tags) { metadata, data in
         guard let metadata, let data else {
           reject("Error", "Could not update metadata", nil)
           return
         }
-        
+
         do {
-          try PHPhotoLibrary.shared().performChangesAndWait{
+          try PHPhotoLibrary.shared().performChangesAndWait {
             let request = PHAssetCreationRequest.forAsset()
             request.addResource(with: .photo, data: data, options: nil)
             request.creationDate = Date()
-            
+
             let newAssetId = request.placeholderForCreatedAsset!.localIdentifier
             resolve([
               "uri": "ph://\(newAssetId)",
               "assetId": newAssetId,
               "tags": getExifTags(from: metadata),
             ])
-            
           }
-        } catch let error {
+        } catch {
           reject("Error", "Could not save to image file", nil)
           print(error)
         }
       }
     }
   }
-  
-  func writeExif(uri: String, tags: [String: Any], resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) -> Void {
+
+  func writeExif(uri: String, tags: [String: Any], resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) {
     guard let url = URL(string: uri) else {
       reject("Error", "Invalid URL", nil)
       return
@@ -98,7 +96,7 @@ class Exify: NSObject {
         reject("Error", "Could not update metadata", nil)
         return
       }
-      
+
       do {
         // Write to the current file
         try data.write(to: url, options: .atomic)
@@ -107,16 +105,15 @@ class Exify: NSObject {
           "uri": uri,
           "tags": getExifTags(from: metadata),
         ])
-        
-      } catch let error {
+      } catch {
         reject("Error", "Could not save to image file", nil)
         print(error)
       }
     }
   }
 
   @objc(readAsync:withResolver:withRejecter:)
-  func readAsync(uri: String, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) -> Void {
+  func readAsync(uri: String, resolve: @escaping RCTPromiseResolveBlock, reject _: @escaping RCTPromiseRejectBlock) {
     if uri.starts(with: "ph://") {
       let assetId = String(uri[uri.index(uri.startIndex, offsetBy: 5)...])
       readExif(assetId: assetId, resolve: resolve)
@@ -126,7 +123,7 @@ class Exify: NSObject {
   }
 
   @objc(writeAsync:withExif:withResolver:withRejecter:)
-  func writeAsync(uri: String, tags: [String: Any], resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) -> Void {
+  func writeAsync(uri: String, tags: [String: Any], resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) {
     if uri.starts(with: "ph://") {
       let assetId = String(uri[uri.index(uri.startIndex, offsetBy: 5)...])
       writeExif(assetId: assetId, tags: tags, resolve: resolve, reject: reject)

Diff for: ios/Exify.swift

@@ -27,64 +27,64 @@ func getAssetsBy(assetIds: [String]) -> PHFetchResult<PHAsset> {
   return PHAsset.fetchAssets(withLocalIdentifiers: assetIds, options: options)
 }
 
-func addTagEntries(from dictionary: CFString, metadata: NSDictionary, to tags: NSMutableDictionary) -> Void {
+func addTagEntries(from dictionary: CFString, metadata: NSDictionary, to tags: NSMutableDictionary) {
   if let entries = metadata[dictionary] as? [String: Any] {
     tags.addEntries(from: entries)
   }
 }
 
 func getExifTags(from metadata: NSDictionary) -> [String: Any] {
   let tags: NSMutableDictionary = [:]
-  
+
   // Add root non-dictionary properties
   for (key, value) in metadata {
     if value as? [String: Any] == nil {
       tags[key] = value
     }
   }
-  
+
   // Append all {Exif} properties
   addTagEntries(from: kCGImagePropertyExifDictionary, metadata: metadata, to: tags)
-  
+
   // Prefix {GPS} dictionary with "GPS"
   if let gps = metadata[kCGImagePropertyGPSDictionary as String] as? [String: Any] {
     for (key, value) in gps {
       tags["GPS" + key] = value
     }
   }
-  
+
   // Include tags from formats
   addTagEntries(from: kCGImagePropertyTIFFDictionary, metadata: metadata, to: tags)
   addTagEntries(from: kCGImagePropertyPNGDictionary, metadata: metadata, to: tags)
   addTagEntries(from: kCGImagePropertyHEICSDictionary, metadata: metadata, to: tags)
-  
-  return tags as! [String: Any]
+
+  return tags as? [String: Any] ?? [:]
 }
 
-func readExifTags(from url: URL?, completionHandler: ([String: Any]?) -> Void) -> Void {
+func readExifTags(from url: URL?, completionHandler: ([String: Any]?) -> Void) {
   guard let url, let sourceImage = CGImageSourceCreateWithURL(url as CFURL, nil),
         let metadataDict = CGImageSourceCopyPropertiesAtIndex(sourceImage, 0, nil) else {
     completionHandler(nil)
     return
   }
-  
+
   let tags = getExifTags(from: metadataDict)
   completionHandler(tags)
 }
 
-func updateMetadata(url: URL, with tags: [String: Any], completionHanlder: (NSDictionary?, Data?) -> Void) -> Void {
+func updateMetadata(url: URL, with tags: [String: Any], completionHanlder: (NSDictionary?, Data?) -> Void) {
   guard let cgImageSource = CGImageSourceCreateWithURL(url as CFURL, nil) else {
     completionHanlder(nil, nil)
     return
   }
-  
+
   let metadataDict = CGImageSourceCopyPropertiesAtIndex(cgImageSource, 0, nil) ?? [:] as CFDictionary
   let metadata = NSMutableDictionary(dictionary: metadataDict)
 
   // Append additional Exif data
   let exifDict = metadata[kCGImagePropertyExifDictionary as String] as? NSMutableDictionary
   exifDict?.addEntries(from: tags)
-  
+
   // Handle GPS Tags
   var gpsDict = [String: Any]()
 
@@ -102,15 +102,14 @@ func updateMetadata(url: URL, with tags: [String: Any], completionHanlder: (NSDi
     gpsDict[kCGImagePropertyGPSAltitude as String] = abs(altitude)
     gpsDict[kCGImagePropertyGPSAltitudeRef as String] = altitude >= 0 ? 0 : 1
   }
-  
+
   if let gpsDate = tags["GPSDateStamp"] as? String {
     gpsDict[kCGImagePropertyGPSDateStamp as String] = gpsDate
   }
-  
+
   if let gpsTime = tags["GPSTimeStamp"] as? String {
     gpsDict[kCGImagePropertyGPSTimeStamp as String] = gpsTime
   }
-  
 
   if metadata[kCGImagePropertyGPSDictionary as String] == nil {
     metadata[kCGImagePropertyGPSDictionary as String] = gpsDict
@@ -119,20 +118,20 @@ func updateMetadata(url: URL, with tags: [String: Any], completionHanlder: (NSDi
       metadataGpsDict.addEntries(from: gpsDict)
     }
   }
-  
+
   metadata.setObject(NSNumber(value: 1), forKey: kCGImageDestinationLossyCompressionQuality as NSString)
-  
+
   let destinationData = NSMutableData()
 
   guard let uiImage = UIImage(contentsOfFile: url.path),
-    let sourceType = CGImageSourceGetType(cgImageSource),
-    let destination = CGImageDestinationCreateWithData(destinationData, sourceType, 1, nil) else {
+        let sourceType = CGImageSourceGetType(cgImageSource),
+        let destination = CGImageDestinationCreateWithData(destinationData, sourceType, 1, nil) else {
     completionHanlder(nil, nil)
     return
   }
 
   CGImageDestinationAddImage(destination, uiImage.cgImage!, metadata)
   CGImageDestinationFinalize(destination)
-  
+
   completionHanlder(metadata, destinationData as Data)
 }

Diff for: ios/ExifyUtils.swift

@@ -31,7 +31,7 @@
     "typecheck": "tsc --noEmit",
     "lint": "eslint --fix \"**/*.{js,ts,tsx}\"",
     "format": "prettier --write \"**/*.{js,ts,tsx}\"",
-    "tidy": "yarn typecheck && yarn lint && yarn format",
+    "tidy": "yarn typecheck && yarn lint && yarn format && scripts/swiftlint.sh && scripts/swiftformat.sh",
     "clean": "del-cli android/build lib && yarn workspace exify-example clean",
     "prepare": "bob build",
     "release": "release-it"

Diff for: package.json

@@ -0,0 +1,8 @@
+#!/bin/bash
+
+if which swiftformat >/dev/null; then
+  cd ios && swiftformat --quiet .
+else
+  echo "error: SwiftFormat not installed, install with 'brew install swiftformat' (or manually from https://github.com/nicklockwood/SwiftFormat)"
+  exit 1
+fi