Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate webkit E2E failure #3454

Closed
corneliusroemer opened this issue Dec 17, 2024 · 1 comment
Closed

Investigate webkit E2E failure #3454

corneliusroemer opened this issue Dec 17, 2024 · 1 comment
Labels
bug Something isn't working e2e E2E test related tests Test related issues

Comments

@corneliusroemer
Copy link
Contributor

corneliusroemer commented Dec 17, 2024

It looks like a new webkit version released in the past 5 days or so since we last ran tests causes our tests to fail. It's unlikely that the backend patch release causes webkit to fail across the board in CI:

30 failed
    [webkit] › pages/index.spec.ts:4:5 › The landing page › contains an organism ───────────────────
    [webkit] › pages/logout/index.spec.ts:4:5 › The user page › should have usable logout button ───
...
    [webkit] › pages/user/index.spec.ts:6:5 › The user page › should see the groups the user is member of, create a submitting group and leave it afterwards 
  2 flaky
    [chromium] › pages/review/index.spec.ts:53:5 › The review page › approve restricted sequences ──
    [firefox] › pages/review/index.spec.ts:53:5 › The review page › approve restricted sequences ───
  7 did not run
  81 passed (6.4m)

See e.g.: https://github.com/loculus-project/loculus/actions/runs/12375060856/job/34538999509

@corneliusroemer corneliusroemer added bug Something isn't working e2e E2E test related tests Test related issues labels Dec 17, 2024
@theosanderson
Copy link
Member

Given that we're not seeing failures now I guess this is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working e2e E2E test related tests Test related issues
Projects
None yet
Development

No branches or pull requests

2 participants