From ce5fd3c6dd7589996935c77bf604eeafc1845814 Mon Sep 17 00:00:00 2001
From: "Anna (Anya) Parker" <50943381+anna-parker@users.noreply.github.com>
Date: Mon, 23 Dec 2024 18:00:05 +0100
Subject: [PATCH] fix warnings

---
 geonames/api.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/geonames/api.py b/geonames/api.py
index 1054bc440a..0f071c5952 100644
--- a/geonames/api.py
+++ b/geonames/api.py
@@ -137,7 +137,9 @@ def post(self):
 
         if file and file.filename.endswith(".tsv"):
             # Save the file to the uploads directory
-            file_path = os.path.join(app.config["UPLOAD_FOLDER"], file.filename)
+            file_path = os.path.normpath(os.path.join(app.config["UPLOAD_FOLDER"], file.filename))
+            if not file_path.startswith(app.config["UPLOAD_FOLDER"]):
+                return {"error": "Invalid file path."}, 400
             file.save(file_path)
 
             # Insert data from the TSV file into the database
@@ -152,4 +154,5 @@ def post(self):
     init_db()
     config = yaml.safe_load(open("config/default.yaml", encoding="utf-8"))
     app.config["insdc_country_code_mapping"] = config.get("insdc_country_code_mapping", {})
-    app.run(debug=True)
+    debug_mode = os.getenv("FLASK_DEBUG", "False").lower() in ("true", "1", "t")
+    app.run(debug=debug_mode)