Refactored IsRevisionable class

Author: ThomasEnssner

composer.json

@@ -43,7 +43,8 @@
     }
   },
   "require-dev": {
-    "orchestra/testbench": "^v9.0.0"
+    "orchestra/testbench": "^v9.0.0",
+    "laravel/pint": "^1.15"
   },
   "extra": {
     "laravel": {

src/Concerns/IsRevisionable.php

@@ -121,19 +121,19 @@ public function postUpdate(): void
 
         if (count($revisions) && $maxRevisionCountReached && ($this->revisionCleanup ?? false)) {
             foreach ($this->revisionHistory()
-                         ->orderBy('id')
-                         ->offset($this->historyLimit - 1)
-                         ->limit(1000)
-                         ->cursor() as $revision) {
+                ->orderBy('id')
+                ->offset($this->historyLimit - 1)
+                ->limit(1000)
+                ->cursor() as $revision) {
                 $revision->delete();
             }
         }
 
         $this->insertRevisions($revisions, 'saved');
 
-        $this->originalData = null;
-        $this->updatedData = null;
-        $this->dirtyData = null;
+        $this->originalData = [];
+        $this->updatedData = [];
+        $this->dirtyData = [];
     }
 
     public function revisionHistory(): MorphMany
@@ -290,13 +290,15 @@ public function postForceDelete()
                 'created_at' => new \DateTime(),
             ];
 
-            Revision::create($revisions);
+            foreach ($revisions as $revision) {
+                Revision::create($revision);
+            }
 
             Event::dispatch('revisionable.deleted', ['model' => $this, 'revisions' => $revisions]);
         }
     }
 
-    public function disableRevisionable()
+    public function disableRevisionable(): void
     {
         $this->revisionEnabled = false;
     }
@@ -326,7 +328,7 @@ public function getRevisionFormattedFieldNames()
      *
      * @return string an identifying name for the model
      */
-    public function identifiableName()
+    public function identifiableName(): string
     {
         return $this->getKey();
     }
@@ -340,7 +342,7 @@ public function identifiableName()
      *
      * @return string an identifying name for the model
      */
-    public function getRevisionNullString()
+    public function getRevisionNullString(): string
     {
         return isset($this->revisionNullString) ? $this->revisionNullString : 'nothing';
     }
@@ -353,7 +355,7 @@ public function getRevisionNullString()
      *
      * @return string an identifying name for the model
      */
-    public function getRevisionUnknownString()
+    public function getRevisionUnknownString(): string
     {
         return isset($this->revisionUnknownString) ? $this->revisionUnknownString : 'unknown';
     }