Skip to content

Commit 39eae4b

Browse files
Rollup merge of #124480 - Enselic:on-broken-pipe, r=jieyouxu
Change `SIGPIPE` ui from `#[unix_sigpipe = "..."]` to `-Zon-broken-pipe=...` In the stabilization [attempt](rust-lang/rust#120832) of `#[unix_sigpipe = "sig_dfl"]`, a concern was [raised ](rust-lang/rust#120832 (comment)) related to using a language attribute for the feature: Long term, we want `fn lang_start()` to be definable by any crate, not just libstd. Having a special language attribute in that case becomes awkward. So as a first step towards the next stabilization attempt, this PR changes the `#[unix_sigpipe = "..."]` attribute to a compiler flag `-Zon-broken-pipe=...` to remove that concern, since now the language is not "contaminated" by this feature. Another point was [also raised](rust-lang/rust#120832 (comment)), namely that the ui should not leak **how** it does things, but rather what the **end effect** is. The new flag uses the proposed naming. This is of course something that can be iterated on further before stabilization. Tracking issue: rust-lang/rust#97889
2 parents 68e3d0f + 938e1a0 commit 39eae4b

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

crates/hir-def/src/attr/builtin.rs

-1
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,6 @@ pub const INERT_ATTRIBUTES: &[BuiltinAttribute] = &[
207207
),
208208

209209
// Entry point:
210-
gated!(unix_sigpipe, Normal, template!(Word, NameValueStr: "inherit|sig_ign|sig_dfl"), ErrorFollowing, experimental!(unix_sigpipe)),
211210
ungated!(start, Normal, template!(Word), WarnFollowing),
212211
ungated!(no_start, CrateLevel, template!(Word), WarnFollowing),
213212
ungated!(no_main, CrateLevel, template!(Word), WarnFollowing),

0 commit comments

Comments
 (0)