Hide data in Domain
#1277
Closed
Hide data in Domain
#1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupek2
reviewed
Dec 2, 2024
Collaborator
tupek2
left a comment
tupek2
left a comment
There was a problem hiding this comment.
Looks good to me, seems like we need to get that new formatting in. Its going crazy on these files.
Member
Author
I agree. In particular, the forced alignment of the right side of |
samuelpmishLLNL
approved these changes
Dec 2, 2024
Member
Author
|
Let's hold this back until I get the boundary condition PR in. I'll handle the conflicts that emerge in this PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on Mike's comment: this changes
Domainfrom a struct to a class, with the expected hiding of internal data.