-
Notifications
You must be signed in to change notification settings - Fork 34
Tupek/contact adjoint #1229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Tupek/contact adjoint #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/style |
4bb9c5a to
bad482e
Compare
2e52fda to
5f42eaf
Compare
Collaborator
Author
|
/style |
eb82e53 to
223474b
Compare
Collaborator
Author
|
/style |
1 similar comment
Collaborator
Author
|
/style |
samuelpmishLLNL
approved these changes
Nov 7, 2024
ebchin
approved these changes
Nov 7, 2024
Member
ebchin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
f4b7a86 to
98e918e
Compare
Collaborator
Author
|
/style |
1 similar comment
Collaborator
Author
|
/style |
Delete copy
…nt states instead of generic mfem vectors.
67221a1 to
6edbdc7
Compare
Collaborator
Author
|
/style |
…ssue to address once we are further along.
… test with multipliers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract solid mechanics a bit to allow for contact jacobian corrections in the adjoint calculations. Gradient test is not super accurate, maybe ~20% off. Hopefully the analytic contact jacobians can fix this, or there is still some error in our adjoint calculations here?