From 37bbc3bf88de4c1b36725d3c00b286a6399ee564 Mon Sep 17 00:00:00 2001 From: sluehrs Date: Fri, 20 May 2016 16:28:05 +0200 Subject: [PATCH 1/2] switched NCMPI write type to MPI_SIGNED_CHAR instead of MPI_BYTE to be compatible with parallel-netcdf 1.7.0 --- src/aiori-NCMPI.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/aiori-NCMPI.c b/src/aiori-NCMPI.c index e3e678f..bbc058f 100644 --- a/src/aiori-NCMPI.c +++ b/src/aiori-NCMPI.c @@ -279,24 +279,24 @@ static IOR_offset_t NCMPI_Xfer(int access, void *fd, IOR_size_t * buffer, if (param->collective) { NCMPI_CHECK(ncmpi_put_vara_all (*(int *)fd, var_id, offset, bufSize, - bufferPtr, length, MPI_BYTE), + bufferPtr, length, MPI_SIGNED_CHAR), "cannot write to data set"); } else { NCMPI_CHECK(ncmpi_put_vara (*(int *)fd, var_id, offset, bufSize, - bufferPtr, length, MPI_BYTE), + bufferPtr, length, MPI_SIGNED_CHAR), "cannot write to data set"); } } else { /* READ or CHECK */ if (param->collective == TRUE) { NCMPI_CHECK(ncmpi_get_vara_all (*(int *)fd, var_id, offset, bufSize, - bufferPtr, length, MPI_BYTE), + bufferPtr, length, MPI_SIGNED_CHAR), "cannot read from data set"); } else { NCMPI_CHECK(ncmpi_get_vara (*(int *)fd, var_id, offset, bufSize, - bufferPtr, length, MPI_BYTE), + bufferPtr, length, MPI_SIGNED_CHAR), "cannot read from data set"); } } From b15926ce87ef7aff66b8754524547beaed74bc93 Mon Sep 17 00:00:00 2001 From: sluehrs Date: Thu, 29 Sep 2016 13:55:02 +0200 Subject: [PATCH 2/2] fix type conversion bug in ncmpi interface --- src/aiori-NCMPI.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/aiori-NCMPI.c b/src/aiori-NCMPI.c index bbc058f..571b5a9 100644 --- a/src/aiori-NCMPI.c +++ b/src/aiori-NCMPI.c @@ -196,7 +196,7 @@ static IOR_offset_t NCMPI_Xfer(int access, void *fd, IOR_size_t * buffer, (IOR_offset_t) ((rank + rankOffset) % param->numTasks) * param->blockSize; } - if ((int)(param->offset - segmentPosition) == 0) { + if ((param->offset - segmentPosition) == (IOR_offset_t)0) { startDataSet = TRUE; /* * this toggle is for the read check operation, which passes through