Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hit object timing point parsing #33

Open
de-odex opened this issue Apr 15, 2018 · 2 comments
Open

hit object timing point parsing #33

de-odex opened this issue Apr 15, 2018 · 2 comments
Labels
beatmap parser Parsing beatmaps bug

Comments

@de-odex
Copy link
Contributor

de-odex commented Apr 15, 2018 •
edited
Loading

image
BPM is incorrect (albeit stated in the docs) when ms/beat is negative, and as per https://osu.ppy.sh/help/wiki/osu!_File_Formats/Osu_(file_format), when ms/beat is negative, it is a percentage of the last inherited timing point

data taken using slider.Beatmap.parse

will attempt fixing
@de-odex
Copy link
Contributor Author

de-odex commented Apr 15, 2018

actually, i'm thinking about why you wouldn't implement this

@llllllllll
Copy link
Owner

I didn't implement this because I didn't know about this, thanks for letting me know! Also, I hadn't seen that doc, the one that existed when I started slider was much less full, thanks for linking that.

@llllllllll llllllllll added bug beatmap parser Parsing beatmaps labels Apr 17, 2018
@de-odex de-odex mentioned this issue Apr 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beatmap parser Parsing beatmaps bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@llllllllll @de-odex