Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lengths longer than the defined curve are not accounted for #111

Open
daymxn opened this issue Jul 6, 2023 · 2 comments
Open

Lengths longer than the defined curve are not accounted for #111

daymxn opened this issue Jul 6, 2023 · 2 comments

Comments

@daymxn
Copy link

daymxn commented Jul 6, 2023

When a Slider has a length property that is longer than the actual curve length, the Slider will extend its curve according to the following rules:

For bézier, catmull, and linear curves, it continues in a straight line from the end of the curve.
For perfect circle curves, it continues the circular arc.

-From the Wiki

This is not currently accounted for. Although, lengths smaller than the defined curve seem to be. It's also worth noting that this is much more common than you'd think; especially when folks don't snap their sliders to the grid.

@daymxn
Copy link
Author

daymxn commented Jul 6, 2023

Note that it appears the wiki is incorrect as far as perfect circle curves; they seem to extend in a straight line (the same as the others).

Although, the noted behavior may be valid for older beatmaps? Worth investigating further.

@tybug
Copy link
Collaborator

tybug commented Jul 11, 2023

Honestly speaking I'm not sure I'll have the bandwidth to look into this in the near future. PRs are always welcome though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants