[Bugfix:InstructorUI] Notify on Self Registration (Submitty#11451)

### What is the current behavior?
Currently all instructors in Submitty are receiving emails when a user
self registers for a course. This is because the function used is just
getting all of a certain type of user.
Closes Submitty#11434 
### What is the new behavior?
This function has two more parameters added, allowing for the ability to
specify if you want that group for a specific course and term.

### Other information?
This changes the SelfRejoin function as well, as that is supposed to
notify the instructors of that given course, not all instructors of
Submitty.
The original use of this function remains unchanged, as `term` and
`course` are optional parameters, and the query defaults to being the
same query as before.

---------

Co-authored-by: Barb Cutler <[email protected]>

Author: IDzyre

site/app/controllers/SelfRejoinController.php

@@ -215,7 +215,7 @@ private function sendRejoinedStudentEmail($joined_section): void {
             you may move the student to the Null section.
         EMAIL;
 
-        $instructor_ids = $this->core->getQueries()->getActiveUserIds(true, false, false, false, false);
+        $instructor_ids = $this->core->getQueries()->getActiveUserIds(true, false, false, false, false, $term, $course);
         $emails = [];
         $details = ["subject" => $subject, "body" => $body];
         foreach ($instructor_ids as $instructor_id) {

site/app/controllers/course/CourseRegistrationController.php

@@ -48,7 +48,7 @@ public function registerCourseUser(string $term, string $course): void {
         $default_section = $this->core->getQueries()->getDefaultRegistrationSection($term, $course);
         $this->core->getUser()->setRegistrationSection($default_section);
         $this->core->getQueries()->insertCourseUser($this->core->getUser(), $term, $course);
-        $instructor_ids = $this->core->getQueries()->getActiveUserIds(true, false, false, false, false);
+        $instructor_ids = $this->core->getQueries()->getActiveUserIds(true, false, false, false, false, $term, $course);
         $this->notifyInstructors($this->core->getUser()->getId(), $term, $course, $instructor_ids);
     }
 }

site/app/libraries/database/DatabaseQueries.php

@@ -1147,7 +1147,7 @@ public function getGroupForUserInClass($semester, $course_name, $user_id) {
      * @param bool $faculty to include faculty level users or not
      * @return array - array of userids active in the specified semester
      */
-    public function getActiveUserIds(bool $instructor, bool $fullAccess, bool $limitedAccess, bool $student, bool $faculty): array {
+    public function getActiveUserIds(bool $instructor, bool $fullAccess, bool $limitedAccess, bool $student, bool $faculty, ?string $term = null, ?string $course = null): array {
         $args = ['-1'];
         $extra_join = '';
         $extra_where = '';
@@ -1168,13 +1168,20 @@ public function getActiveUserIds(bool $instructor, bool $fullAccess, bool $limit
             $extra_join = ' INNER JOIN users ON courses_users.user_id = users.user_id ';
             $extra_where = ' OR users.user_access_level <= 2';
         }
+        $on_phrase = ' ON courses_users.term = courses.term AND courses_users.course = courses.course ';
+        $parameters = $args;
+        if ($term !== null && $course !== null) {
+            $parameters = [$term, $course];
+            $parameters = array_merge($parameters, $args);
+            $on_phrase = ' ON courses_users.term = ? AND courses_users.course = ? ';
+        }
         $result_rows = [];
         $this->submitty_db->query(
             "SELECT DISTINCT courses_users.user_id as user_id
                 FROM courses_users INNER JOIN courses
-                ON courses_users.term = courses.term AND courses_users.course = courses.course
-                " . $extra_join . "
-                WHERE courses.status = 1 AND user_group IN (" . implode(', ', $args) . ")" . $extra_where
+                " . $on_phrase . $extra_join . "
+                WHERE courses.status = 1 AND user_group IN " . $this->createParameterList(count($args)) . $extra_where,
+            $parameters
         );
         return array_map(
             function ($row) {