Skip to content

Commit f3f4b2a

Browse files
committed
fix: telemetry tests no longer reference old telemetry system
1 parent df137d8 commit f3f4b2a

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

tests/integration/telemetry/collectors/in_memory.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,10 @@
1515
from opentelemetry.sdk.trace.export import SimpleSpanProcessor
1616
from opentelemetry.sdk.trace.export.in_memory_span_exporter import InMemorySpanExporter
1717

18-
import llama_stack.core.telemetry.telemetry as telemetry_module
19-
2018
from .base import BaseTelemetryCollector, MetricStub, SpanStub
2119

2220

21+
# TODO: Fix thi to work with Automatic Instrumentation
2322
class InMemoryTelemetryCollector(BaseTelemetryCollector):
2423
"""In-memory telemetry collector for library-client tests.
2524
@@ -75,13 +74,10 @@ def __init__(self) -> None:
7574
meter_provider = MeterProvider(metric_readers=[metric_reader])
7675
metrics.set_meter_provider(meter_provider)
7776

78-
telemetry_module._TRACER_PROVIDER = tracer_provider
79-
8077
self.collector = InMemoryTelemetryCollector(span_exporter, metric_reader)
8178
self._tracer_provider = tracer_provider
8279
self._meter_provider = meter_provider
8380

8481
def shutdown(self) -> None:
85-
telemetry_module._TRACER_PROVIDER = None
8682
self._tracer_provider.shutdown()
8783
self._meter_provider.shutdown()

tests/integration/telemetry/conftest.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
from tests.integration.telemetry.collectors import InMemoryTelemetryManager, OtlpHttpTestCollector
1616

1717

18+
# TODO: Fix this to work with Automatic Instrumentation
1819
@pytest.fixture(scope="session")
1920
def telemetry_test_collector():
2021
stack_mode = os.environ.get("LLAMA_STACK_TEST_STACK_CONFIG_TYPE", "library_client")
@@ -48,6 +49,7 @@ def telemetry_test_collector():
4849
manager.shutdown()
4950

5051

52+
# TODO: Fix this to work with Automatic Instrumentation
5153
@pytest.fixture(scope="session")
5254
def llama_stack_client(telemetry_test_collector, request):
5355
"""Ensure telemetry collector is ready before initializing the stack client."""

0 commit comments

Comments
 (0)