Skip to content

Commit c8ae29e

Browse files
author
tomaioo
authored
Security: Verbose Logging of Sensitive Audio Data (#438)
## Summary Security: Verbose Logging of Sensitive Audio Data ## Problem **Severity**: `Medium` | **File**: `ios/audio/AudioSinkRenderer.swift:L17` The `AudioSinkRenderer` logs the base64 encoded audio data, its length, and other metadata using `NSLog`. This verbose logging can expose sensitive audio stream data in the device's console logs, which could be intercepted by other processes or during debugging sessions. ## Solution Remove the `NSLog` statements that print the audio data payload and its length. If logging is necessary for debugging, use a conditional debug flag and avoid logging raw data payloads. ## Changes - `ios/audio/AudioSinkRenderer.swift` (modified) Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
1 parent 8a105f0 commit c8ae29e

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

‎ios/audio/AudioSinkRenderer.swift‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,6 @@ public class AudioSinkRenderer: BaseAudioSinkRenderer {
2424
let length = Int(pcmBuffer.frameCapacity * pcmBuffer.format.streamDescription.pointee.mBytesPerFrame)
2525
let data = NSData(bytes: channels[0], length: length)
2626
let base64 = data.base64EncodedString()
27-
NSLog("AUDIO DATA!!!!")
28-
NSLog("\(data.length)")
29-
NSLog(base64)
30-
NSLog("\(base64.count)")
31-
NSLog("\(length)")
3227
eventEmitter.sendEvent(withName: LKEvents.kEventAudioData, body: [
3328
"data": base64,
3429
"id": reactTag

0 commit comments

Comments
 (0)