Skip to content

fix(agents): Introduced a final transcription buffer for chatCtx fix #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

affablebloke
Copy link

Fix incomplete messages in chatCtx introduced in #301

When the transcription forwarder was replaced with the text-audio synchronizer in PR #301, it introduced a regression where incomplete messages were being added to chatCtx. This PR resolves that by ensuring only finalized or properly buffered messages are pushed to the chat context.

Why:

We observed that chatCtx was receiving cut-off or partial transcriptions, often just the last sentence, which negatively affected the AI’s responses and also broke VPAEvent.AGENT_SPEECH_COMMITTED.

Discussion:

This raises a broader design question about interruptions and the agent’s chatCtx: Should the agent commit its full, uninterrupted message to chatCtx, or just the portion spoken before the interruption? In this PR, I opted to commit the interrupted message, but this is arguably a subjective design choice.

…ted text more effectively, ensuring accurate agent speech commits are added to chatCtx
Copy link

changeset-bot bot commented Jun 5, 2025

⚠️ No Changeset found

Latest commit: fab4189

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jun 5, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants