Skip to content
This repository was archived by the owner on Sep 16, 2021. It is now read-only.
This repository was archived by the owner on Sep 16, 2021. It is now read-only.

Any suggestions about fixing tests from BitcoindComparisonTool? #1

@ultragtx

Description

@ultragtx

Bitcoin uses BitcoindComparisonTool.jar to test bitcoind , the jar is downloaded from theuni/bitcoind-comparisontool (source code theuni/bitcoinj: A library for working with Bitcoin) which is a JAVA implementation of Bitcoin protocol (bitcoinj).

Obviously litecoin cannot pass the tests from BitcoindComparisonTool.jar because the whole library is written for bitcoin which has some different blockchain parameters and some different implementations.

So we have two options here

  1. Maintain a fork of bitcoinj, do all the necessary changes, make it litecoinj, it's not worth to maintain a whole library just for a unit test.
  2. Disable this test, which zcash choose, Disable comparison utility by str4d · Pull Request #800 · zcash/zcash

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions