Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Fix] Missing opening brackets in external_trigger.yml #156

Closed
1 task done
ilike2burnthing opened this issue Dec 11, 2024 · 1 comment
Closed
1 task done
Assignees

Comments

@ilike2burnthing
Copy link

ilike2burnthing commented Dec 11, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Per PR instructions I'm opening this as an issue, as it appears to just be a typo.

https://github.com/linuxserver/docker-jackett/blob/master/.github/workflows/external_trigger.yml#L93

-               if "${artifacts_found}" == "true" ]]; then
+               if [[ "${artifacts_found}" == "true" ]]; then

Introduced in c406221, was causing the error line 77: : command not found in the step External Trigger:

@aptalca
Copy link
Member

aptalca commented Dec 11, 2024

Yeah, this is a typo in our jenkins builder template, but it only affects a log message and doesn't fail the trigger. That's why we didn't notice it before.

https://github.com/linuxserver/docker-jenkins-builder/blob/master/roles/generate-jenkins/templates/EXTERNAL_TRIGGER.j2#L185

Thanks for the heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants