Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Use release tag instead of latest on S3 to split up branch build results #54

Closed
1 task done
aptalca opened this issue Aug 29, 2024 · 0 comments · Fixed by #55
Closed
1 task done

[FEAT] Use release tag instead of latest on S3 to split up branch build results #54

aptalca opened this issue Aug 29, 2024 · 0 comments · Fixed by #55
Labels
enhancement New feature or request

Comments

@aptalca
Copy link
Member

aptalca commented Aug 29, 2024

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Accept an env var RELEASE_TAG and use that value for S3 folder instead of a hardcoded latest here:

latest_dir: str = f"{self.image}/latest"

That way results of different live branches can be in separate folders and can be linked in separate badges.

Reason for change

Currently, all live branch results are uploaded to S3 bucket into a latest folder. In the readmes, we link to the result in the latest folder. However, for images with more than one release tag, such as radarr (latest, development and nightly), the results from these 3 live branches are all mixed in, which leads to the master branch readme showing a badge linking to the latest of those 3, rather than linking to the result of that branch's latest build.

Proposed code change

I opened this PR for the jenkins-builder so that once the ci image pushes to dedicated folders on S3, the readmes can link to the correct latest result for that specific branch: linuxserver/docker-jenkins-builder#279

Ci image needs to be updated first. Updating ci won't really break anything. It's just that all branch readmes will show the master/main build results until updated by the jenkins builder after linuxserver/docker-jenkins-builder#279 is merged

@aptalca aptalca added the enhancement New feature or request label Aug 29, 2024
@GilbN GilbN closed this as completed in #55 Sep 3, 2024
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
1 participant